From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#21833: 24.4; desktop-kill, which is interactive, is in kill-emacs-hook Date: Thu, 12 Nov 2015 22:50:01 +0200 Message-ID: <83wptngcxy.fsf@gnu.org> References: <5644F186.1000405@siancu.net> <5644F584.5060205@siancu.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1447361482 6749 80.91.229.3 (12 Nov 2015 20:51:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 12 Nov 2015 20:51:22 +0000 (UTC) Cc: 21833@debbugs.gnu.org To: Stelian Iancu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 12 21:51:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zwypq-0000Z3-Lf for geb-bug-gnu-emacs@m.gmane.org; Thu, 12 Nov 2015 21:51:11 +0100 Original-Received: from localhost ([::1]:49723 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zwypp-0006dh-CT for geb-bug-gnu-emacs@m.gmane.org; Thu, 12 Nov 2015 15:51:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58474) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zwypm-0006dc-JN for bug-gnu-emacs@gnu.org; Thu, 12 Nov 2015 15:51:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zwypi-0000nr-Lb for bug-gnu-emacs@gnu.org; Thu, 12 Nov 2015 15:51:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44441) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zwypi-0000nn-ID for bug-gnu-emacs@gnu.org; Thu, 12 Nov 2015 15:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Zwypi-0000EI-C8 for bug-gnu-emacs@gnu.org; Thu, 12 Nov 2015 15:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Nov 2015 20:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21833 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21833-submit@debbugs.gnu.org id=B21833.1447361420833 (code B ref 21833); Thu, 12 Nov 2015 20:51:02 +0000 Original-Received: (at 21833) by debbugs.gnu.org; 12 Nov 2015 20:50:20 +0000 Original-Received: from localhost ([127.0.0.1]:35149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zwyp1-0000DM-6m for submit@debbugs.gnu.org; Thu, 12 Nov 2015 15:50:19 -0500 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:38864) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zwyoy-0000DD-Qz for 21833@debbugs.gnu.org; Thu, 12 Nov 2015 15:50:17 -0500 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NXP00500YS4XW00@a-mtaout23.012.net.il> for 21833@debbugs.gnu.org; Thu, 12 Nov 2015 22:50:15 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NXP005NSZ7QX020@a-mtaout23.012.net.il>; Thu, 12 Nov 2015 22:50:15 +0200 (IST) In-reply-to: <5644F584.5060205@siancu.net> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108684 Archived-At: > From: Stelian Iancu > Date: Thu, 12 Nov 2015 21:24:36 +0100 > Cc: 21833@debbugs.gnu.org > > On 12/11/15 21:11, Glenn Morris wrote: > > > > The point is that kill-emacs-hook is not supposed to contain interactive > > things. > > > > Thanks for the clarification. > > I've had a look at the code and desktop-kill is added to the > kill-emacs-hook in desktop.el: > > (unless noninteractive > (add-hook 'kill-emacs-hook 'desktop-kill)) > > So I guess the fix would be to remove these two lines, right? Not exactly. From the ELisp manual: -- Variable: kill-emacs-hook This normal hook is run by `kill-emacs', before it kills Emacs. Because `kill-emacs' can be called in situations where user interaction is impossible (e.g., when the terminal is disconnected), functions on this hook should not attempt to interact with the user. If you want to interact with the user when Emacs is shutting down, use `kill-emacs-query-functions', described below. So I think the hook should be added to kill-emacs-query-functions, since we still want to ask the user that question, when appropriate.