From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Suggest: dont declare interactive-p obsolete Date: Thu, 19 Nov 2015 17:29:45 +0200 Message-ID: <83wpte80t2.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1447947087 8289 80.91.229.3 (19 Nov 2015 15:31:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 19 Nov 2015 15:31:27 +0000 (UTC) Cc: emacs-devel@gnu.org, raman@google.com To: John Wiegley Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 19 16:31:20 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZzRB9-00028K-HQ for ged-emacs-devel@m.gmane.org; Thu, 19 Nov 2015 16:31:19 +0100 Original-Received: from localhost ([::1]:42494 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzRB8-0000XI-W3 for ged-emacs-devel@m.gmane.org; Thu, 19 Nov 2015 10:31:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36009) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzRA0-0007AI-4g for emacs-devel@gnu.org; Thu, 19 Nov 2015 10:30:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZzR9v-0003Kh-0H for emacs-devel@gnu.org; Thu, 19 Nov 2015 10:30:08 -0500 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:65517) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzR9u-0003K9-PP for emacs-devel@gnu.org; Thu, 19 Nov 2015 10:30:02 -0500 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NY200000ISEND00@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Thu, 19 Nov 2015 17:30:00 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NY2000UVJ20O000@a-mtaout22.012.net.il>; Thu, 19 Nov 2015 17:30:00 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:194790 Archived-At: > From: John Wiegley > Date: Wed, 18 Nov 2015 20:16:21 -0800 > Cc: emacs-devel@gnu.org > > >>>>> raman writes: > > > This is a minor change -- that will let existing code run without warnings. > > If we turned the defun in subr.el to a defsubst and dropped the (declare > > (obsolete called-interactively-p "23.2")) (called-interactively-p > > 'interactive)) > > I don't see any downsides to this; others? Because we want to cause Lisp programs not to use it? There's only a handful of users of this in Emacs -- why not simply rewrite them to use called-interactively-p? If we deprecated it, we should be the first to remove it, no? I really don't see any reasons to revert our decision because of few places that need to be cleaned up.