From: Eli Zaretskii <eliz@gnu.org>
To: John Wiegley <jwiegley@gmail.com>
Cc: emacs-devel@gnu.org, raman@google.com
Subject: Re: Suggest: dont declare interactive-p obsolete
Date: Thu, 19 Nov 2015 17:29:45 +0200 [thread overview]
Message-ID: <83wpte80t2.fsf@gnu.org> (raw)
In-Reply-To: <m24mgi7hey.fsf@newartisans.com>
> From: John Wiegley <jwiegley@gmail.com>
> Date: Wed, 18 Nov 2015 20:16:21 -0800
> Cc: emacs-devel@gnu.org
>
> >>>>> raman <raman@google.com> writes:
>
> > This is a minor change -- that will let existing code run without warnings.
> > If we turned the defun in subr.el to a defsubst and dropped the (declare
> > (obsolete called-interactively-p "23.2")) (called-interactively-p
> > 'interactive))
>
> I don't see any downsides to this; others?
Because we want to cause Lisp programs not to use it?
There's only a handful of users of this in Emacs -- why not simply
rewrite them to use called-interactively-p? If we deprecated it, we
should be the first to remove it, no?
I really don't see any reasons to revert our decision because of few
places that need to be cleaned up.
next prev parent reply other threads:[~2015-11-19 15:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 1:57 Suggest: dont declare interactive-p obsolete raman
2015-11-19 4:16 ` John Wiegley
2015-11-19 8:39 ` Artur Malabarba
2015-11-19 13:06 ` Andreas Röhler
2015-11-19 13:46 ` Dmitry Gutov
2015-11-20 7:29 ` Andreas Röhler
2015-11-19 13:44 ` Dmitry Gutov
2015-11-19 15:29 ` Eli Zaretskii [this message]
2015-11-19 16:25 ` John Wiegley
2015-11-19 17:32 ` raman
2015-11-19 17:47 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wpte80t2.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jwiegley@gmail.com \
--cc=raman@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.