From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Windows 9X crash Date: Sat, 16 Jan 2016 11:15:09 +0200 Message-ID: <83wpr9evhe.fsf@gnu.org> References: <568BBC58.50702@aprikoodi.fi> <83y4c43qkh.fsf@gnu.org> <5691667C.5000009@aprikoodi.fi> <838u3wkkvb.fsf@gnu.org> <5694E07E.8010005@aprikoodi.fi> <83fuy2kd2w.fsf@gnu.org> <56961607.2090504@aprikoodi.fi> <569634D6.6030404@aprikoodi.fi> <83oacpiial.fsf@gnu.org> <5697995B.5010306@aprikoodi.fi> <83mvs8gh7n.fsf@gnu.org> <56989810.70301@aprikoodi.fi> <5698A546.8020701@aprikoodi.fi> <831t9jgt8y.fsf@gnu.org> <5698BD58.2090708@aprikoodi.fi> <83oacnf8ne.fsf@gnu.org> <5698CAF3.5020402@aprikoodi.fi> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1452935739 14540 80.91.229.3 (16 Jan 2016 09:15:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 16 Jan 2016 09:15:39 +0000 (UTC) Cc: fabrice.popineau@gmail.com, emacs-devel@gnu.org To: Jussi Lahdenniemi Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 16 10:15:32 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aKMxF-0002ht-PN for ged-emacs-devel@m.gmane.org; Sat, 16 Jan 2016 10:15:29 +0100 Original-Received: from localhost ([::1]:50145 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aKMxE-0007OL-V0 for ged-emacs-devel@m.gmane.org; Sat, 16 Jan 2016 04:15:28 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37694) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aKMx1-0007Nh-7w for emacs-devel@gnu.org; Sat, 16 Jan 2016 04:15:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aKMwx-0005V5-Ar for emacs-devel@gnu.org; Sat, 16 Jan 2016 04:15:15 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38835) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aKMwx-0005V1-7E; Sat, 16 Jan 2016 04:15:11 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2179 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aKMwv-0001dh-A8; Sat, 16 Jan 2016 04:15:09 -0500 In-reply-to: <5698CAF3.5020402@aprikoodi.fi> (message from Jussi Lahdenniemi on Fri, 15 Jan 2016 12:33:23 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:198187 Archived-At: > Cc: fabrice.popineau@gmail.com, emacs-devel@gnu.org > From: Jussi Lahdenniemi > Date: Fri, 15 Jan 2016 12:33:23 +0200 > > On 15.1.2016 12.18, Eli Zaretskii wrote: > > I think the 9X-specific code should be #ifdef'ed away in 64-bit > > builds, is that right? The alignment code and the "p - 1" stuff is > > wrong for 64-bit code anyway, I think. > > It can be #ifdef'd away if wanted, but it's not used on 64-bit OSes > anyway (due to the "if (os_subtype == OS_9X)" in init_heap), and it's > not causing any warnings or errors in the 64-bit build process. > > Of course, should Microsoft release a 64-bit version of the Windows 9X > family appear on the market, then the code would be broken :) > > The "p-1" stuff would not be broken for a 64-bit Windows 98, though; the > "+8"s would (they should be "+12" to ensure enough room for 64-bit > void*s). But then again, the theoretical 64-bit Windows 98 would most > probably HeapAllocate on 8-byte boundaries - and in that case, the code > would work perfectly as-is. OK, I pushed the patch to the emacs-25 branch. Thanks.