all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Alan Mackenzie <acm@muc.de>
Cc: emacs-devel@gnu.org
Subject: Re: The future of Follow Mode - a proposal.
Date: Sat, 20 Feb 2016 15:05:16 +0200	[thread overview]
Message-ID: <83wppzo7lf.fsf@gnu.org> (raw)
In-Reply-To: <20160220124415.GA1758@acm.fritz.box> (message from Alan Mackenzie on Sat, 20 Feb 2016 12:44:15 +0000)

> Date: Sat, 20 Feb 2016 12:44:15 +0000
> Cc: emacs-devel@gnu.org
> From: Alan Mackenzie <acm@muc.de>
> 
> > The functions we talk about currently don't know what they are invoked
> > for.  Your envisioned changes imply that they should behave
> > differently depending on whether the results will be used for layout
> > of the current window or the next/previous window in a group.  That's
> > part of the changes I had in mind.  They are not trivial.  But without
> > them, what you want to do will not work reliably.
> 
> How about adding an extra boolean parameter to the move_it_* functions,
> perhaps called `physical', which when set would mean the function would
> have to adjust its iterator when crossing a window boundary, when not set
> would work the same way as it currently does?  `vertical-motion' would
> also need this extra &optional parameter, possibly a few other defuns,
> too.

I don't think it's a boolean.  It should be the buffer position where
the window should be switched.  So probably 2 parameters, for the
beginning and end of the window.  Maybe also the window to switch to.

And then you need to implement the handling of these new arguments.

> There are around 150 calls to move_it_*.  I'm guessing that most of these
> would set `physical' to false, perhaps more of the ones in window.c would
> use true.

Maybe, I don't know.  The problem is that these functions are called
in several layers, and all of them will have to know about these new
arguments.  Also, some utility functions, like pos_visible_p, are
called in different situations, so the caller will have to supply
those arguments as required in each case.

> > > As an example, `compute_window_start_on_continuation_line' would have to
> > > use the dimensions of the previous window to determine the window-start.
> > > Jiggling the various windows around after text changes or scrolling is
> > > going to be the hard part of the coding.
> 
> > Yes, and the result will be non-trivial changes in the overall logic,
> > because redisplaying a window will no longer be independent of other
> > windows.
> 
> Yes.  This is what is currently implemented in Follow Mode.

No, I mean that redisplay of all the windows in a group will have to
be done in one go, not one window at a time.



  reply	other threads:[~2016-02-20 13:05 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-18 19:56 The future of Follow Mode - a proposal Alan Mackenzie
2016-02-18 20:24 ` Eli Zaretskii
2016-02-19 14:25   ` Alan Mackenzie
2016-02-19 14:34     ` martin rudalics
2016-02-19 16:12       ` Eli Zaretskii
2016-02-19 16:08     ` Eli Zaretskii
2016-02-19 18:18       ` Alan Mackenzie
2016-02-19 18:45         ` Eli Zaretskii
2016-02-20 12:44           ` Alan Mackenzie
2016-02-20 13:05             ` Eli Zaretskii [this message]
2016-02-23 23:11               ` Alan Mackenzie
2016-02-24  3:57                 ` Stefan Monnier
2016-02-24 17:14                   ` Eli Zaretskii
2016-02-24 18:57                     ` Stefan Monnier
2016-02-24 19:19                       ` Eli Zaretskii
2016-02-24 20:10                         ` Stefan Monnier
2016-02-24 20:21                           ` Eli Zaretskii
2016-02-25  0:30                             ` Stefan Monnier
2016-02-25 16:28                               ` Eli Zaretskii
2016-02-25 16:46                                 ` Stefan Monnier
2016-02-25 17:29                                   ` Eli Zaretskii
2016-02-25 20:30                                 ` Alan Mackenzie
2016-02-25 20:57                       ` Alan Mackenzie
2016-02-25 21:10                         ` Stefan Monnier
2016-02-25 22:17                           ` Alan Mackenzie
2016-02-28 16:40                             ` Stefan Monnier
2016-02-24 18:34                 ` Eli Zaretskii
2016-02-25 20:18                   ` Alan Mackenzie
2016-02-19 14:56   ` Anders Lindgren
2016-02-19 16:30     ` Eli Zaretskii
2016-02-19 18:45       ` Alan Mackenzie
2016-02-18 20:41 ` John Yates
2016-02-19 16:21   ` Alan Mackenzie
2016-02-19 16:32     ` Eli Zaretskii
2016-02-19 19:25     ` John Yates
2016-02-19 20:27       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83wppzo7lf.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.