all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Nikolay Kudryavtsev <nikolay.kudryavtsev@gmail.com>
Cc: 23075@debbugs.gnu.org
Subject: bug#23075: 24.5; vc-git-command should use coding-system-for-read
Date: Mon, 21 Mar 2016 18:16:14 +0200	[thread overview]
Message-ID: <83wpov6c35.fsf@gnu.org> (raw)
In-Reply-To: <56EFD97C.3080805@gmail.com> (message from Nikolay Kudryavtsev on Mon, 21 Mar 2016 14:22:36 +0300)

> From: Nikolay Kudryavtsev <nikolay.kudryavtsev@gmail.com>
> Date: Mon, 21 Mar 2016 14:22:36 +0300
> 
> If you have files in your repositories, that are in different coding 
> system from vc-git-commits-coding-system, vc-diff would still show diffs 
> for them in vc-git-commits-coding-system.
> 
> This is unnecessary, since vc-diff-internal already decides what coding 
> system to use based on the first file and then sets 
> coding-system-for-read accordingly.
> 
> The fix is to change vc-git-command to use coding-system-for-read 
> whenever it's bound.

Please show a recipe for reproducing this problem with a recent Git
version and preferably with the latest pretest of Emacs 25.1.  Please
include any files necessary for the reproduction.  Before we dive into
this tricky issue, I'd like to be sure the problem still exists (since
more than a year has passed since your original reports).

Also, this is specific to MS-Windows, right?

Thanks.





  reply	other threads:[~2016-03-21 16:16 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-21 11:22 bug#23075: 24.5; vc-git-command should use coding-system-for-read Nikolay Kudryavtsev
2016-03-21 16:16 ` Eli Zaretskii [this message]
2016-03-21 16:54   ` Óscar Fuentes
2016-03-21 17:21     ` Eli Zaretskii
2016-03-21 17:57     ` Andreas Schwab
2016-03-21 18:05       ` Óscar Fuentes
2016-03-21 18:22         ` Eli Zaretskii
2016-03-21 19:38           ` Óscar Fuentes
2016-04-02 10:02             ` Eli Zaretskii
2016-03-21 18:20       ` Eli Zaretskii
2016-03-21 18:45         ` Nikolay Kudryavtsev
2016-03-21 19:17           ` Eli Zaretskii
2016-03-21 19:35             ` Nikolay Kudryavtsev
2016-04-02  9:58           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83wpov6c35.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=23075@debbugs.gnu.org \
    --cc=nikolay.kudryavtsev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.