From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24956: 26.0.50; On Windows, setting PATH in compilation-environment has no effect Date: Fri, 18 Nov 2016 11:46:28 +0200 Message-ID: <83wpg1ce8b.fsf@gnu.org> References: <87wpg383pb.fsf@telefonica.net> <83k2c1esbp.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1479462615 4920 195.159.176.226 (18 Nov 2016 09:50:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 18 Nov 2016 09:50:15 +0000 (UTC) Cc: ofv@wanadoo.es, 24956@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 18 10:50:08 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c7fo8-0000gS-2G for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Nov 2016 10:50:08 +0100 Original-Received: from localhost ([::1]:35403 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7foB-0004lB-GV for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Nov 2016 04:50:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33299) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7flC-0002v8-9D for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2016 04:47:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7fl8-00029D-28 for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2016 04:47:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45950) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c7fl7-000299-UX for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2016 04:47:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c7fl7-0002f4-Mb for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2016 04:47:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Nov 2016 09:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 24956-submit@debbugs.gnu.org id=B24956.147946239610197 (code B ref 24956); Fri, 18 Nov 2016 09:47:01 +0000 Original-Received: (at 24956) by debbugs.gnu.org; 18 Nov 2016 09:46:36 +0000 Original-Received: from localhost ([127.0.0.1]:33116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c7fki-0002eP-0F for submit@debbugs.gnu.org; Fri, 18 Nov 2016 04:46:36 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:42221) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c7fkg-0002eE-Lv for 24956@debbugs.gnu.org; Fri, 18 Nov 2016 04:46:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7fkX-00023x-4i for 24956@debbugs.gnu.org; Fri, 18 Nov 2016 04:46:29 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33482) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7fkX-00023s-1I; Fri, 18 Nov 2016 04:46:25 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2350 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1c7fkW-0001YM-7y; Fri, 18 Nov 2016 04:46:24 -0500 In-reply-to: (message from Noam Postavsky on Thu, 17 Nov 2016 16:27:17 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125823 Archived-At: > From: Noam Postavsky > Date: Thu, 17 Nov 2016 16:27:17 -0500 > Cc: Óscar Fuentes , 24956@debbugs.gnu.org > > >> (let ((process-environment (cons "Path=d:\\foo" process-environment))) > >> (call-process "cmd" nil '(t t) nil "/C" "echo %PATH%")) > >> > >> inserts "d:\foo". In Emacs 25.1, or reverting the commit I mentioned, > >> the opposite occurs. > > > > I think this is because PATH doesn't exist in the original environment > > inherited from the shell, only Path does. We push PATH into the > > environment only in w32.c:init_environment (and do the same trick with > > ComSpec vs COMSPEC). But since the above-mentioned change, that > > function no longer affects process-environment. > > > > So to fix this bug, we need to push PATH and COMSPEC into > > process-environment, replacing their camel-case variants. > > > > Does this make sense? > > Yes. https://cygwin.com/cygwin-ug-net/using-cygwinenv.html lists a few > other variables that it upcases (at the bottom of the page), should we > do those ones as well? No, I don't think so. (Some of those are up-cased in the original environment on my machine, anyway.) Let's not do something like that without a good reason. Thanks.