From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25332: [PATCH] Change while loops to for loops. Date: Sat, 07 Jan 2017 10:30:12 +0200 Message-ID: <83wpe7b7cb.fsf@gnu.org> References: <87h95hdg0w.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1483777881 12773 195.159.176.226 (7 Jan 2017 08:31:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 7 Jan 2017 08:31:21 +0000 (UTC) Cc: 25332@debbugs.gnu.org To: Chris Gregory Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 07 09:31:18 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPmP8-0001m7-ME for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Jan 2017 09:31:10 +0100 Original-Received: from localhost ([::1]:56457 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPmPB-000761-HY for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Jan 2017 03:31:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59934) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPmP4-00074t-4P for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2017 03:31:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cPmP0-0008Hr-Ut for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2017 03:31:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58411) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cPmP0-0008Hn-RH for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2017 03:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cPmP0-0000hR-Lq for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2017 03:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Jan 2017 08:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25332 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25332-submit@debbugs.gnu.org id=B25332.148377781232148 (code B ref 25332); Sat, 07 Jan 2017 08:31:02 +0000 Original-Received: (at 25332) by debbugs.gnu.org; 7 Jan 2017 08:30:12 +0000 Original-Received: from localhost ([127.0.0.1]:45577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPmOC-0008MJ-Kw for submit@debbugs.gnu.org; Sat, 07 Jan 2017 03:30:12 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:40584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPmOA-0008FG-Ux for 25332@debbugs.gnu.org; Sat, 07 Jan 2017 03:30:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cPmO1-0007vx-VZ for 25332@debbugs.gnu.org; Sat, 07 Jan 2017 03:30:05 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43975) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPmNs-0007ti-Ey; Sat, 07 Jan 2017 03:29:52 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1973 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cPmNr-0007fd-08; Sat, 07 Jan 2017 03:29:51 -0500 In-reply-to: <87h95hdg0w.fsf@gmail.com> (message from Chris Gregory on Mon, 02 Jan 2017 00:26:07 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127869 Archived-At: tags 25332 notabug close 25332 thanks > From: Chris Gregory > Date: Mon, 02 Jan 2017 00:26:07 -0800 > > This patch changes while loops to for loops to make the code more > consistent. I don't think I understand the rationale. Why is using 'while' inconsistent? In any case, please don't bother making style changes in ralloc.c, as that file should almost never be used in Emacs, except in some marginal configurations, and we actually would like to get rid of it altogether. It's therefore a waste of effort to try to make its style better.