From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Emacs 26.1 release branch created Date: Fri, 22 Sep 2017 23:11:39 +0300 Message-ID: <83wp4qbiis.fsf@gnu.org> References: <83377mls4d.fsf@gnu.org> <87bmmazt77.fsf@udel.edu> <83zi9ukbj3.fsf@gnu.org> <20170916145112.GA22458@holos.localdomain> <83wp4yk7ve.fsf@gnu.org> <20170922165941.sirfk6qzfvdfw4i2@logos.localdomain> <83zi9mbj2g.fsf@gnu.org> <20170922200503.u6ipjtezrsoth4xx@logos.localdomain> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1506111126 25316 195.159.176.226 (22 Sep 2017 20:12:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 22 Sep 2017 20:12:06 +0000 (UTC) Cc: emacs-devel@gnu.org To: Mark Oteiza Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 22 22:12:02 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvUIs-0006HH-60 for ged-emacs-devel@m.gmane.org; Fri, 22 Sep 2017 22:12:02 +0200 Original-Received: from localhost ([::1]:60848 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvUIz-0004oH-Fk for ged-emacs-devel@m.gmane.org; Fri, 22 Sep 2017 16:12:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:32968) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvUIn-0004mn-Dq for emacs-devel@gnu.org; Fri, 22 Sep 2017 16:11:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dvUIi-0004vZ-Tt for emacs-devel@gnu.org; Fri, 22 Sep 2017 16:11:57 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47626) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvUIi-0004vV-Qi; Fri, 22 Sep 2017 16:11:52 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1081 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dvUIh-0004WG-4u; Fri, 22 Sep 2017 16:11:52 -0400 In-reply-to: <20170922200503.u6ipjtezrsoth4xx@logos.localdomain> (message from Mark Oteiza on Fri, 22 Sep 2017 16:05:03 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218708 Archived-At: > Date: Fri, 22 Sep 2017 16:05:03 -0400 > From: Mark Oteiza > Cc: emacs-devel@gnu.org > > > Hmm... I'm probably missing something, because I don't understand the > > rationale and the intent of your changes. You introduce a static > > function lcms2_available_p that is not used anywhere else in the file? > > Oops, all the instances of replacing #ifdef'd code with > init_lcms_functions were meant to instead be calling lcms_available_p. > Hopefully that makes the intent clear. Yes, clear. > > And you removed lcms2-available-p without which Lisp code cannot know > > at run time whether lcms2 support is available or not? Where does > > this lead? > > I don't think having it in Lisp is necessary--isn't it essentially the > same as (featurep 'lcms2)? No, not on MS-Windows. An Emacs binary compiled with lcms2 support, then moved to a system where lcms2 libraries are not installed will return t from featurep, but the lcms2 functions will signal an error.