all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Allen Li <vianchielfaura@gmail.com>
Cc: 28615-done@debbugs.gnu.org
Subject: bug#28615: [PATCH] Clarify what grep-read-files wants
Date: Mon, 09 Oct 2017 16:41:23 +0300	[thread overview]
Message-ID: <83wp44qvzw.fsf@gnu.org> (raw)
In-Reply-To: <CAJr1M6ffi9yeU6rGNuioAr6+8DP4+8S_Hz+SLWSky3O7G2QgqA@mail.gmail.com> (message from Allen Li on Wed, 4 Oct 2017 21:15:32 -0700)

> From: Allen Li <vianchielfaura@gmail.com>
> Date: Wed, 4 Oct 2017 21:15:32 -0700
> 
> grep-read-files wants a filename glob, not a filename/path.
> 
> * lisp/progmodes/grep.el (grep-read-files): Clarify docstring.
>   Use file aliases for completion.
>   Clarify completing-read prompt.

Thanks, I installed a slightly different change for the first 2 parts,
but didn't change the function we pass to completing-read.

With that, I'm closing the bug report.





  reply	other threads:[~2017-10-09 13:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-27  7:01 bug#28615: 25.3; rgrep, grep-read-files confusingly completes file names ヌエルモリノ
2017-10-05  4:15 ` bug#28615: [PATCH] Clarify what grep-read-files wants Allen Li
2017-10-09 13:41   ` Eli Zaretskii [this message]
2017-10-10  4:43     ` Allen Li
2017-10-10  5:55       ` Eli Zaretskii
2017-10-10  6:51         ` Allen Li
2017-10-10  7:52           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83wp44qvzw.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=28615-done@debbugs.gnu.org \
    --cc=vianchielfaura@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.