From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 1/2] Use Jansson's error code support if available Date: Tue, 19 Dec 2017 21:54:15 +0200 Message-ID: <83wp1io5nc.fsf@gnu.org> References: <20171218231730.38840-1-phst@google.com> <83zi6eod7a.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1513713209 29788 195.159.176.226 (19 Dec 2017 19:53:29 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 19 Dec 2017 19:53:29 +0000 (UTC) Cc: phst@google.com, emacs-devel@gnu.org To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 19 20:53:25 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRNx3-00077h-O2 for ged-emacs-devel@m.gmane.org; Tue, 19 Dec 2017 20:53:21 +0100 Original-Received: from localhost ([::1]:34534 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRNz0-0002Np-GC for ged-emacs-devel@m.gmane.org; Tue, 19 Dec 2017 14:55:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50650) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRNxp-0002MO-Pi for emacs-devel@gnu.org; Tue, 19 Dec 2017 14:54:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eRNxp-00069F-1s for emacs-devel@gnu.org; Tue, 19 Dec 2017 14:54:09 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37767) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRNxk-00064N-WB; Tue, 19 Dec 2017 14:54:05 -0500 Original-Received: from [176.228.60.248] (port=2623 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eRNxk-0002nA-CH; Tue, 19 Dec 2017 14:54:04 -0500 In-reply-to: (message from Philipp Stephani on Tue, 19 Dec 2017 17:35:48 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221257 Archived-At: > From: Philipp Stephani > Date: Tue, 19 Dec 2017 17:35:48 +0000 > Cc: emacs-devel@gnu.org, phst@google.com > > The json_error_code function is inline, is it still necessary to load it from the DLL? No, inline functions are okay.