From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] Improve error reporting when serializing non-Unicode
	strings to JSON
Date: Sat, 23 Dec 2017 15:44:31 +0200
Message-ID: <83wp1dk18g.fsf@gnu.org>
References: <20171222210031.30811-1-phst@google.com> <83efnllufm.fsf@gnu.org>
	<CAArVCkTCmhSmT_Yip1r99NvZwiB3hB0rMzkpvu3ame_tq4UMtA@mail.gmail.com>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: blaine.gmane.org
X-Trace: blaine.gmane.org 1514036567 20618 195.159.176.226 (23 Dec 2017 13:42:47 GMT)
X-Complaints-To: usenet@blaine.gmane.org
NNTP-Posting-Date: Sat, 23 Dec 2017 13:42:47 +0000 (UTC)
Cc: phst@google.com, emacs-devel@gnu.org
To: Philipp Stephani <p.stephani2@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 23 14:42:42 2017
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by blaine.gmane.org with esmtp (Exim 4.84_2)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1eSk4W-0004tl-St
	for ged-emacs-devel@m.gmane.org; Sat, 23 Dec 2017 14:42:41 +0100
Original-Received: from localhost ([::1]:42035 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1eSk6V-00006w-Ef
	for ged-emacs-devel@m.gmane.org; Sat, 23 Dec 2017 08:44:43 -0500
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35806)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1eSk6N-00006q-JU
	for emacs-devel@gnu.org; Sat, 23 Dec 2017 08:44:36 -0500
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1eSk6M-0006zS-Ss
	for emacs-devel@gnu.org; Sat, 23 Dec 2017 08:44:35 -0500
Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43255)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1eSk6H-0006wh-Sa; Sat, 23 Dec 2017 08:44:29 -0500
Original-Received: from [176.228.60.248] (port=3849 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1eSk6H-0006dV-7a; Sat, 23 Dec 2017 08:44:29 -0500
In-reply-to: <CAArVCkTCmhSmT_Yip1r99NvZwiB3hB0rMzkpvu3ame_tq4UMtA@mail.gmail.com>
	(message from Philipp Stephani on Sat, 23 Dec 2017 12:33:46 +0000)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:221371
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/221371>

> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Sat, 23 Dec 2017 12:33:46 +0000
> Cc: emacs-devel@gnu.org, phst@google.com
> 
> This patch only improves the error symbol when trying to serialize a non-Unicode string to JSON. Right now
> this raises "out of memory", which is somewhat confusing. This patch improves this to raise
> "wrong-type-argument".

OK, but why do we need external functions for doing that?  What is
missing in our own code to detect such a situation?