all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: charles@aurox.ch (Charles A. Roelli)
Cc: 28732@debbugs.gnu.org
Subject: bug#28732: flymake mouse-wheel portability fix
Date: Tue, 27 Feb 2018 21:31:33 +0200	[thread overview]
Message-ID: <83woyyz0tm.fsf@gnu.org> (raw)
In-Reply-To: <m2fu5mi651.fsf@aurox.ch> (charles@aurox.ch)

> Date: Tue, 27 Feb 2018 20:28:42 +0100
> From: charles@aurox.ch (Charles A. Roelli)
> Cc: 28732@debbugs.gnu.org
> 
> Thanks.  Is the following change (ignoring whitespace differences)
> good for emacs-26?
> 
> diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
> index 58bad8f..d58c5943 100644
> --- a/lisp/progmodes/flymake.el
> +++ b/lisp/progmodes/flymake.el
> @@ -1078,7 +1078,9 @@
>                       face ,face
>                       mouse-face mode-line-highlight
>                       keymap
> -                     ,(let ((map (make-sparse-keymap))
> +                     ,(when (and (boundp 'mouse-wheel-down-event)
> +                                 (boundp 'mouse-wheel-up-event))
> +                        (let ((map (make-sparse-keymap))

Is there any reason you cannot simply require mwheel in flymake?  Or
does loading mwheel in a --without-x build fail?





  reply	other threads:[~2018-02-27 19:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-07 15:31 bug#28732: flymake mouse-wheel portability fix Charles A. Roelli
2017-10-21 13:06 ` Charles A. Roelli
2018-02-26 21:38 ` Glenn Morris
2018-02-27 19:28   ` Charles A. Roelli
2018-02-27 19:31     ` Eli Zaretskii [this message]
2018-02-28 19:02       ` Charles A. Roelli
2018-02-28 20:32         ` Eli Zaretskii
2018-03-01 19:43           ` Charles A. Roelli
2018-03-02  2:10         ` Noam Postavsky
2018-03-03 10:43           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83woyyz0tm.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=28732@debbugs.gnu.org \
    --cc=charles@aurox.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.