Re: [Emacs-diffs] emacs-26 613c9a5: Update Org to v9.1.9

Re: [Emacs-diffs] emacs-26 613c9a5: Update Org to v9.1.9

[Eli Zaretskii]

> From: rasmus@gmx.us (pank)
> To: emacs-diffs@gnu.org
> Date: Tue, 27 Mar 2018 17:38:26 -0400 (EDT)
> Subject: [Emacs-diffs] emacs-26 613c9a5: Update Org to v9.1.9
> 
> branch: emacs-26
> commit 613c9a5c1f3237fbdc3a3db2341c7c59353d2aa2
> Author: Rasmus <rasmus@gmx.us>
> Commit: Rasmus <rasmus@gmx.us>
> 
>     Update Org to v9.1.9
>     
>     Please note this is a bugfix release. See etc/ORG-NEWS for details.

Thanks, but this merge should have been discussed first.  Most of its
changes are no-brainers, but some are non-trivial, and we should have
talked about them before the merge, to make sure we understand all the
tradeoffs, and indeed the changes are safe for Emacs 26.1.

Re: [Emacs-diffs] emacs-26 613c9a5: Update Org to v9.1.9

[Rasmus]

Hi Eli,

Sorry about the late reply.  I have been travelling.

Eli Zaretskii <eliz@gnu.org> writes:

>> From: rasmus@gmx.us (pank)
>> To: emacs-diffs@gnu.org
>
>> Date: Tue, 27 Mar 2018 17:38:26 -0400 (EDT)
>> Subject: [Emacs-diffs] emacs-26 613c9a5: Update Org to v9.1.9
>> 
>> branch: emacs-26
>> commit 613c9a5c1f3237fbdc3a3db2341c7c59353d2aa2
>> Author: Rasmus <rasmus@gmx.us>
>> Commit: Rasmus <rasmus@gmx.us>
>> 
>>     Update Org to v9.1.9
>>     
>>     Please note this is a bugfix release. See etc/ORG-NEWS for details.
>
> Thanks, but this merge should have been discussed first.  Most of its
> changes are no-brainers, but some are non-trivial, and we should have
> talked about them before the merge, to make sure we understand all the
> tradeoffs, and indeed the changes are safe for Emacs 26.1.

These should all be bugfixes and should not alter features.  In general,
minor release changes relate to bug reports on the Org mailing list or
debbugs.

Are there any changes in particular that are concerning?  If so, it may be
possible to role them forward to the next major version of Org.

Thanks,
Rasmus

-- 
To err is human. To screw up 10⁶ times per second, you need a computer

Re: [Emacs-diffs] emacs-26 613c9a5: Update Org to v9.1.9

[Eli Zaretskii]

> From: Rasmus <rasmus@gmx.us>
> Date: Mon, 02 Apr 2018 14:30:18 +0200
> Cc: bzg@gnu.org
> 
> Sorry about the late reply.  I have been travelling.

No need to apologize, we all have our "real" lives.

> >>     Update Org to v9.1.9
> >>     
> >>     Please note this is a bugfix release. See etc/ORG-NEWS for details.
> >
> > Thanks, but this merge should have been discussed first.  Most of its
> > changes are no-brainers, but some are non-trivial, and we should have
> > talked about them before the merge, to make sure we understand all the
> > tradeoffs, and indeed the changes are safe for Emacs 26.1.
> 
> These should all be bugfixes and should not alter features.  In general,
> minor release changes relate to bug reports on the Org mailing list or
> debbugs.

I understand, but experience taught me that different people tend to
see bugfixes from different perspectives and assess their risks
differently.  It's quite possible that, have you described the
non-trivial changes, we'd all agree that they are safe enough.  But it
could be that some of them would have been considered too risky.

> Are there any changes in particular that are concerning?

I was generally worried by all the non-trivial, non-documentation
changes, because this merge came so late in the pretest process.  I
didn't review them thoroughly enough to say anything specific, or
focus on any of them in particular.

Re: [Emacs-diffs] emacs-26 613c9a5: Update Org to v9.1.9

[Rasmus]

Hi Eli,

Thanks for the explanation.

Eli Zaretskii <eliz@gnu.org> writes:

>> >>     Update Org to v9.1.9
>> >>     
>> >>     Please note this is a bugfix release. See etc/ORG-NEWS for details.
>> >
>> > Thanks, but this merge should have been discussed first.  Most of its
>> > changes are no-brainers, but some are non-trivial, and we should have
>> > talked about them before the merge, to make sure we understand all the
>> > tradeoffs, and indeed the changes are safe for Emacs 26.1.
>> 
>> These should all be bugfixes and should not alter features.  In general,
>> minor release changes relate to bug reports on the Org mailing list or
>> debbugs.
>
> I understand, but experience taught me that different people tend to
> see bugfixes from different perspectives and assess their risks
> differently.  It's quite possible that, have you described the
> non-trivial changes, we'd all agree that they are safe enough.  But it
> could be that some of them would have been considered too risky.

I am happy to put together a change log if that would be helpful.  We have
a change log entry for each change.

In the future, if we are close to a release I’ll obviously ping the list
before merging a new version, even if deemed minor from the Org devs point
of view.

Thanks,
Rasmus

-- 
Lasciate ogni speranza o voi che entrate: siete nella mani di'machellaio

Re: [Emacs-diffs] emacs-26 613c9a5: Update Org to v9.1.9

[Eli Zaretskii]

> From: Rasmus <rasmus@gmx.us>
> Cc: emacs-devel@gnu.org, bzg@gnu.org
> Date: Sat, 07 Apr 2018 21:05:10 +0200
> 
> In the future, if we are close to a release I’ll obviously ping the list
> before merging a new version, even if deemed minor from the Org devs point
> of view.

Thanks in advance.