From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31988: scroll-other-window broken on master Date: Sat, 07 Jul 2018 16:50:47 +0300 Message-ID: <83wou7i288.fsf@gnu.org> References: <87sh57ncom.fsf@tcd.ie> <18f5ace80f052837c724d942d832a146.squirrel@dancol.org> <874lhc9fax.fsf@tcd.ie> <7e1589a2b0bdd4a07d6826b594a96ab5.squirrel@dancol.org> <83pnzzjxl5.fsf@gnu.org> <87a7r317we.fsf@tcd.ie> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1530971345 21004 195.159.176.226 (7 Jul 2018 13:49:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 7 Jul 2018 13:49:05 +0000 (UTC) Cc: 31988@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 07 15:49:01 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbna8-0005Jn-73 for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Jul 2018 15:49:00 +0200 Original-Received: from localhost ([::1]:33774 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fbncF-0002Mw-Bz for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Jul 2018 09:51:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39171) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fbnc8-0002Mr-Uu for bug-gnu-emacs@gnu.org; Sat, 07 Jul 2018 09:51:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fbnc6-0006X4-CY for bug-gnu-emacs@gnu.org; Sat, 07 Jul 2018 09:51:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41348) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fbnc6-0006Wu-7y for bug-gnu-emacs@gnu.org; Sat, 07 Jul 2018 09:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fbnc5-0004QY-TV for bug-gnu-emacs@gnu.org; Sat, 07 Jul 2018 09:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Jul 2018 13:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31988 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 31988-submit@debbugs.gnu.org id=B31988.153097145317005 (code B ref 31988); Sat, 07 Jul 2018 13:51:01 +0000 Original-Received: (at 31988) by debbugs.gnu.org; 7 Jul 2018 13:50:53 +0000 Original-Received: from localhost ([127.0.0.1]:49245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbnbx-0004QD-HG for submit@debbugs.gnu.org; Sat, 07 Jul 2018 09:50:53 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:48150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbnbw-0004Py-3C for 31988@debbugs.gnu.org; Sat, 07 Jul 2018 09:50:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fbnbn-0006GO-Lf for 31988@debbugs.gnu.org; Sat, 07 Jul 2018 09:50:46 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53135) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fbnbn-0006GA-HL; Sat, 07 Jul 2018 09:50:43 -0400 Original-Received: from [176.228.60.248] (port=2025 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fbnbn-0003rl-1C; Sat, 07 Jul 2018 09:50:43 -0400 In-reply-to: <87a7r317we.fsf@tcd.ie> (contovob@tcd.ie) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148298 Archived-At: > From: "Basil L. Contovounesios" > Cc: Daniel Colascione , <31988@debbugs.gnu.org>, <31988-done@debbugs.gnu.org> > Date: Sat, 07 Jul 2018 16:40:17 +0300 > > I don't yet feel particularly good at or confident with writing > changelog entries, let alone Emacs C code, so any guidance is more than > welcome now and in the future. I think you are doing just fine, thank you. There's always some learning curve, of course. CONTRIBUTE should tell you enough, and you can study the log messages by veterans to pick up the spirit. The "inaccurate" part in my message related not to your wording (which was fine, AFAICT), but to the fact that the important part of your fix was to call save-excursion in the described case, not the part that set the buffer (which was actually a no-op). > I'm not sure whether Daniel's addition of the 'close' tag had the > intended effect It should have, but it looks like it didn't for some reason. > so I'm taking the liberty of CCing <31988-done@debbugs.gnu.org>; if > this was the wrong thing to do, please let me know what I should > have done instead. Doing that for a bug that should be closed can never do any harm, even if it was already closed. (You also don't need to CC both NNN@ and NNN-done@, as the message gets recorded by the tracker even if you only use the latter.) Thanks.