all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Andy Moreton <andrewjmoreton@gmail.com>
Cc: 25967@debbugs.gnu.org
Subject: bug#25967: [PATCH] Add support for ImageMagick 7 (Bug#25967)
Date: Tue, 04 Sep 2018 20:11:49 +0300	[thread overview]
Message-ID: <83wos1xk4q.fsf@gnu.org> (raw)
In-Reply-To: <86wos25gvy.fsf@gmail.com> (message from Andy Moreton on Mon, 03 Sep 2018 23:57:05 +0100)

> From: Andy Moreton <andrewjmoreton@gmail.com>
> Date: Mon, 03 Sep 2018 23:57:05 +0100
> 
> As a followup, here is a patch to add ImageMagick support for Windows.
> The patch was initially developed for Imagemagick 6, but I've updated it
> to support ImageMagick 7.
> 
> I've given this some light testing on a 64bit mingw64 (MSYS2) and 64bit
> cygwin builds, both of which use Imagemagick 7.
> 
> Please test, and report if it breaks anything on other platforms.

Thanks.  A couple of minor comments:

This needs a NEWS entry.

> +       '(imagemagick "libMagickWand-7.Q16HDRI-6.dll")))

Is this DLL name fixed for all the supported versions?  It sounds
like it's only for Imagemagick v7, and so the DLL for version 6 will
be named differently.

Also, AFAIU, there are binary incompatibilities between v6 and v7, so
an Emacs compiled with one of them should not attempt to load DLLs
from another, is that right?

For these two reasons, I think we should have a Lisp variable that
provides the version of Imagemagick with which Emacs was built, and we
need the dispatch in w32-win.el for loading the correct DLLs based on
that variable, like we do with libgif etc.





  reply	other threads:[~2018-09-04 17:11 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-04 16:17 bug#25967: 25.1; Support for ImageMagick 7 Tej Chajed
2017-03-10 19:03 ` Paul Eggert
2017-07-24 16:41   ` Glenn Morris
2017-07-24 22:15     ` Paul Eggert
2017-07-25  1:25       ` Glenn Morris
2017-09-02 13:06         ` Eli Zaretskii
2017-09-03  1:10           ` Glenn Morris
2017-12-12 16:59             ` Glenn Morris
2017-12-12 17:15               ` Marcin Borkowski
2017-12-12 17:44                 ` Glenn Morris
2018-06-01 19:17 ` bug#25967: [PATCH] Add support for ImageMagick 7 (Bug#25967) Karl Otness
2018-06-23 10:09   ` Kévin Le Gouguec
2018-06-25 21:08     ` Karl Otness
2018-08-28  2:10   ` Glenn Morris
2018-08-28 20:32     ` Karl Otness
2018-08-30 18:00       ` Glenn Morris
2018-08-30 21:53         ` Karl Otness
2018-08-29  3:21     ` Karl Otness
2018-09-03 22:57   ` Andy Moreton
2018-09-04 17:11     ` Eli Zaretskii [this message]
2018-09-04 19:03       ` Andy Moreton
2018-09-05  2:38         ` Eli Zaretskii
2018-08-28  2:12 ` bug#25967: 25.1; Support for ImageMagick 7 Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83wos1xk4q.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=25967@debbugs.gnu.org \
    --cc=andrewjmoreton@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.