From: Eli Zaretskii <eliz@gnu.org>
To: Federico Tedin <federicotedin@gmail.com>
Cc: juri@linkov.net, 32777@debbugs.gnu.org
Subject: bug#32777: 27.0.50; window-buffer gets wrong point
Date: Tue, 02 Oct 2018 06:21:30 +0300 [thread overview]
Message-ID: <83wor12fut.fsf@gnu.org> (raw)
In-Reply-To: <CAA8GjPkfiaq4LCF8ZzWy7q9upECXVF2OQijT8=BnJQeema30PQ@mail.gmail.com> (message from Federico Tedin on Mon, 1 Oct 2018 23:07:41 -0300)
> From: Federico Tedin <federicotedin@gmail.com>
> Date: Mon, 1 Oct 2018 23:07:41 -0300
> Cc: 32777@debbugs.gnu.org
>
> --- a/lisp/simple.el
> +++ b/lisp/simple.el
> @@ -1710,9 +1710,10 @@ read-extended-command
> (lambda ()
> ;; Get a command name at point in the original buffer
> ;; to propose it after M-n.
> - (with-current-buffer (window-buffer (minibuffer-selected-window))
> - (and (commandp (function-called-at-point))
> - (format "%S" (function-called-at-point)))))))
> + (with-selected-window (minibuffer-selected-window)
> + (with-current-buffer (window-buffer (selected-window))
> + (and (commandp (function-called-at-point))
> + (format "%S" (function-called-at-point))))))))
> ;; Read a string, completing from and restricting to the set of
> ;; all defined commands. Don't provide any initial input.
> ;; Save the command read on the extended-command history list.
Can you explain the change? The minibuffer window is already the
selected window at this point (look at the implementation of
minibuffer-selected-window), so using with-selected-window, which
seems to be the only real change in the above, should be redundant.
Also, with-selected-window makes the window's buffer current, so why
did you need with-current-buffer in addition? What am I missing?
Thanks.
next prev parent reply other threads:[~2018-10-02 3:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 22:55 bug#32777: 27.0.50; window-buffer gets wrong point Juri Linkov
2018-09-30 4:03 ` Federico Tedin
2018-10-02 2:07 ` Federico Tedin
2018-10-02 3:21 ` Eli Zaretskii [this message]
2018-10-02 12:31 ` Federico Tedin
2018-10-13 9:19 ` Eli Zaretskii
2018-10-13 13:08 ` martin rudalics
2018-10-15 7:56 ` martin rudalics
2018-12-21 0:18 ` Juri Linkov
2018-12-21 9:15 ` martin rudalics
2018-12-21 16:02 ` Eli Zaretskii
2018-12-23 9:40 ` martin rudalics
2018-12-29 9:59 ` martin rudalics
2018-12-29 23:10 ` Juri Linkov
2018-12-30 9:49 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wor12fut.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=32777@debbugs.gnu.org \
--cc=federicotedin@gmail.com \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.