From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Replace trivial pcase occurrences in the Emacs sources Date: Thu, 01 Nov 2018 06:15:51 +0200 Message-ID: <83wopxh1qg.fsf@gnu.org> References: <20151216202605.GA3752@acm.fritz.box> <5689456A.1010601@yandex.ru> <87egdy8tyz.fsf@fencepost.gnu.org> <56895FDE.4060406@yandex.ru> <8760za8r4a.fsf@fencepost.gnu.org> <87h9iunkcg.fsf@web.de> <87h8hc4xw2.fsf_-_@web.de> <83tvlcsnee.fsf@gnu.org> <87pnw037ar.fsf@web.de> <83ftwvs7y9.fsf@gnu.org> <877ei7mkfh.fsf@web.de> <87a7mze7tl.fsf@web.de> <831s89mo03.fsf@gnu.org> <87pnvsifxt.fsf@web.de> <83muqwkkt1.fsf@gnu.org> <875zxjv3ku.fsf@web.de> <83o9bbjqcj.fsf@gnu.org> <87r2g7t7bo.fsf@web.de> <83tvl2hzt6.fsf@gnu.org> <87r2g5x3gk.fsf@web.de> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1541045653 12701 195.159.176.226 (1 Nov 2018 04:14:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 1 Nov 2018 04:14:13 +0000 (UTC) Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 01 05:14:09 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gI4Mz-0003E2-38 for ged-emacs-devel@m.gmane.org; Thu, 01 Nov 2018 05:14:09 +0100 Original-Received: from localhost ([::1]:34919 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gI4P5-0005Ca-D7 for ged-emacs-devel@m.gmane.org; Thu, 01 Nov 2018 00:16:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43682) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gI4Ot-0005Be-FB for emacs-devel@gnu.org; Thu, 01 Nov 2018 00:16:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gI4Os-0004Q3-QN for emacs-devel@gnu.org; Thu, 01 Nov 2018 00:16:07 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50175) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gI4Os-0004Pr-LF; Thu, 01 Nov 2018 00:16:06 -0400 Original-Received: from [176.228.60.248] (port=3367 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gI4Os-00083D-8C; Thu, 01 Nov 2018 00:16:06 -0400 In-reply-to: <87r2g5x3gk.fsf@web.de> (message from Michael Heerdegen on Wed, 31 Oct 2018 21:31:55 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230938 Archived-At: > From: Michael Heerdegen > Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org > Date: Wed, 31 Oct 2018 21:31:55 +0100 > > > Not sure I follow: fixing _all_ of them will be _less_ work for you? > > I mean less work in summa. > > > I'm okay with only fixing pcase usage at this time, if you feel that > > would be enough for one changeset. > > It would be ok for me to do both at once if that's also ok for you. It's fine. > > Really? Can you show a few examples? Maybe there's something wrong > > with our documentation if people make such mistakes. > > Here is the result of a quick search. As Stefan said, I don't say we > should fix (all of) these. But some really look strange. There are > many quoted strings - I wonder if these quotes change the behavior of > the compiler or so? I tiny fraction of the matches may be cases where > the quote is significant, e.g. when located in a quoted structure, like > in '('1). I agree that we should fix those. I'm surprised we have so many of them. Thanks.