From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [Emacs-diffs] master cd06d17: Fix bug with face-id after
	restoring from pdump
Date: Mon, 28 Jan 2019 20:14:00 +0200
Message-ID: <83womo3b13.fsf@gnu.org>
References: <20190128152540.6870.46132@vcs0.savannah.gnu.org>
	<20190128152541.12A4D20B50@vcs0.savannah.gnu.org>
	<aef7c61d-3650-57d7-03ef-706fadb88653@dancol.org>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="176939"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: Daniel Colascione <dancol@dancol.org>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 28 19:58:27 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1goC71-000jtS-94
	for ged-emacs-devel@m.gmane.org; Mon, 28 Jan 2019 19:58:27 +0100
Original-Received: from localhost ([127.0.0.1]:37073 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1goC70-000676-9b
	for ged-emacs-devel@m.gmane.org; Mon, 28 Jan 2019 13:58:26 -0500
Original-Received: from eggs.gnu.org ([209.51.188.92]:42086)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1goBQF-0005eo-0i
	for emacs-devel@gnu.org; Mon, 28 Jan 2019 13:14:15 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56073)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1goBQE-0003Wi-AF; Mon, 28 Jan 2019 13:14:14 -0500
Original-Received: from [176.228.60.248] (port=2347 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1goBQD-0002Wt-Ma; Mon, 28 Jan 2019 13:14:14 -0500
In-reply-to: <aef7c61d-3650-57d7-03ef-706fadb88653@dancol.org> (message from
	Daniel Colascione on Mon, 28 Jan 2019 08:05:13 -0800)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:232770
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/232770>

> From: Daniel Colascione <dancol@dancol.org>
> Date: Mon, 28 Jan 2019 08:05:13 -0800
> 
> On 1/28/19 7:25 AM, Eli Zaretskii wrote:
> > branch: master
> > commit cd06d173a602bf0aa8a227ff1626dc70013fe480
> > Author: Eli Zaretskii <eliz@gnu.org>
> > Commit: Eli Zaretskii <eliz@gnu.org>
> > 
> >      Fix bug with face-id after restoring from pdump
> 
> I was going to fix this problem by just turning lface_id_to_name into a 
> normal Lisp vector and using its size as the next face ID. Why use this 
> more complicated approach?

Based on previous discussion regarding frames and faces, I was under
the impression that you prefer moving stuff to the startup of emacs.
I'm not wed to my solution, feel free to change if you think it's
better.