From: Eli Zaretskii <eliz@gnu.org>
To: Daniel Colascione <dancol@dancol.org>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master cd06d17: Fix bug with face-id after restoring from pdump
Date: Mon, 28 Jan 2019 20:14:00 +0200 [thread overview]
Message-ID: <83womo3b13.fsf@gnu.org> (raw)
In-Reply-To: <aef7c61d-3650-57d7-03ef-706fadb88653@dancol.org> (message from Daniel Colascione on Mon, 28 Jan 2019 08:05:13 -0800)
> From: Daniel Colascione <dancol@dancol.org>
> Date: Mon, 28 Jan 2019 08:05:13 -0800
>
> On 1/28/19 7:25 AM, Eli Zaretskii wrote:
> > branch: master
> > commit cd06d173a602bf0aa8a227ff1626dc70013fe480
> > Author: Eli Zaretskii <eliz@gnu.org>
> > Commit: Eli Zaretskii <eliz@gnu.org>
> >
> > Fix bug with face-id after restoring from pdump
>
> I was going to fix this problem by just turning lface_id_to_name into a
> normal Lisp vector and using its size as the next face ID. Why use this
> more complicated approach?
Based on previous discussion regarding frames and faces, I was under
the impression that you prefer moving stuff to the startup of emacs.
I'm not wed to my solution, feel free to change if you think it's
better.
next prev parent reply other threads:[~2019-01-28 18:14 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190128152540.6870.46132@vcs0.savannah.gnu.org>
[not found] ` <20190128152541.12A4D20B50@vcs0.savannah.gnu.org>
2019-01-28 16:05 ` [Emacs-diffs] master cd06d17: Fix bug with face-id after restoring from pdump Daniel Colascione
2019-01-28 18:14 ` Eli Zaretskii [this message]
2019-01-28 19:37 ` Daniel Colascione
2019-01-28 20:19 ` Eli Zaretskii
2019-01-28 17:58 ` Glenn Morris
2019-01-28 20:05 ` Eli Zaretskii
2019-01-28 20:12 ` Flymake and the 'face' property (was: master cd06d17: Fix bug with face-id after restoring from pdump) Eli Zaretskii
2019-01-28 20:39 ` João Távora
2019-01-28 20:57 ` Eli Zaretskii
2019-01-28 21:38 ` João Távora
2019-01-29 16:54 ` Eli Zaretskii
[not found] ` <CALDnm53FnkT+fjneg3uLNMsCu1MxJK1aKWQyvz85EjVdOyr4bg@mail.gmail.com>
2019-01-29 17:26 ` Fwd: " João Távora
2019-01-29 17:51 ` Eli Zaretskii
2019-01-29 17:54 ` Daniel Colascione
2019-01-29 18:30 ` Eli Zaretskii
2019-01-29 18:43 ` Fwd: Flymake and the 'face' property Daniel Colascione
2019-01-29 19:19 ` Eli Zaretskii
2019-01-29 18:47 ` Fwd: Flymake and the 'face' property (was: master cd06d17: Fix bug with face-id after restoring from pdump) João Távora
2019-01-29 18:53 ` Fwd: Flymake and the 'face' property Daniel Colascione
2019-01-29 19:00 ` João Távora
2019-01-29 19:21 ` Fwd: Flymake and the 'face' property (was: master cd06d17: Fix bug with face-id after restoring from pdump) Eli Zaretskii
2019-01-29 19:28 ` João Távora
2019-01-29 18:28 ` João Távora
2019-01-29 18:34 ` Fwd: Flymake and the 'face' property Johan Bockgård
2019-01-29 18:49 ` João Távora
2019-01-29 19:17 ` Eli Zaretskii
2019-01-29 19:33 ` João Távora
2019-01-29 19:48 ` Eli Zaretskii
2019-01-29 19:58 ` João Távora
2019-01-30 9:37 ` Stefan Monnier
2019-01-30 15:40 ` Eli Zaretskii
2019-01-30 17:05 ` João Távora
2019-01-30 18:01 ` Eli Zaretskii
2019-01-30 20:56 ` Stefan Monnier
2019-01-31 3:38 ` Eli Zaretskii
2019-02-02 8:23 ` Stefan Monnier
2019-02-02 10:12 ` Eli Zaretskii
2019-02-02 22:49 ` Stefan Monnier
2019-02-03 3:39 ` Eli Zaretskii
2019-02-03 12:35 ` Stefan Monnier
2019-01-29 17:52 ` Fwd: Flymake and the 'face' property (was: master cd06d17: Fix bug with face-id after restoring from pdump) Daniel Colascione
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83womo3b13.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dancol@dancol.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.