From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master b01a429: js--re-search-backward-inner: Fix infloop Date: Sat, 02 Feb 2019 09:31:53 +0200 Message-ID: <83womiwsra.fsf@gnu.org> References: <20190201000223.22803.66102@vcs0.savannah.gnu.org> <20190201000224.6638E20B45@vcs0.savannah.gnu.org> <6f4122fb-8dcc-836d-9b80-388d417f8cc2@yandex.ru> <83a7jgynk5.fsf@gnu.org> <1312a80d-c09f-c64a-b0ff-d03fa6217574@yandex.ru> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="157639"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 02 08:42:54 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gppwy-000ev6-IY for ged-emacs-devel@m.gmane.org; Sat, 02 Feb 2019 08:42:52 +0100 Original-Received: from localhost ([127.0.0.1]:38801 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gppwx-0006qb-Ax for ged-emacs-devel@m.gmane.org; Sat, 02 Feb 2019 02:42:51 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53903) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gppmg-0006ei-09 for emacs-devel@gnu.org; Sat, 02 Feb 2019 02:32:14 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59863) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gppmf-0007Rh-S9; Sat, 02 Feb 2019 02:32:13 -0500 Original-Received: from [176.228.60.248] (port=4991 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gppmf-0002io-Fq; Sat, 02 Feb 2019 02:32:13 -0500 In-reply-to: <1312a80d-c09f-c64a-b0ff-d03fa6217574@yandex.ru> (message from Dmitry Gutov on Sat, 2 Feb 2019 03:08:09 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232901 Archived-At: > Cc: emacs-devel@gnu.org > From: Dmitry Gutov > Date: Sat, 2 Feb 2019 03:08:09 +0300 > > On 01.02.2019 10:28, Eli Zaretskii wrote: > > > When was this issue introduced? > > One could say it was in 77ab7f84550993b44550879e10cd917b7bf02d04 > (2015-03-05) where support for multiline string literals was added, but > the code expecting the strings to be exactly single-line was not updated. > > >> The bug was reported only recently, but it seems pretty annoying > >> (infloop during indentation), and the fix is simple. > > > > Taken at face value, it doesn't look simple: you are switching from > > using 2 elements of what syntax-ppss returns to a 3rd one. How do we > > know this won't introduce other issues? Maybe if you describe the > > logic of the change, I will agree with you. > > The purpose of the code is get out of the current literal. In the clause > that was changes, to go to the beginning of the enclosing string. > > (goto-char (nth 8 parse)) is a reliable way to do that. The same > function does that for comments anyway. OK, please backport this. Thanks.