From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master b01a429: js--re-search-backward-inner: Fix infloop
Date: Sat, 02 Feb 2019 09:31:53 +0200 [thread overview]
Message-ID: <83womiwsra.fsf@gnu.org> (raw)
In-Reply-To: <1312a80d-c09f-c64a-b0ff-d03fa6217574@yandex.ru> (message from Dmitry Gutov on Sat, 2 Feb 2019 03:08:09 +0300)
> Cc: emacs-devel@gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Sat, 2 Feb 2019 03:08:09 +0300
>
> On 01.02.2019 10:28, Eli Zaretskii wrote:
>
> > When was this issue introduced?
>
> One could say it was in 77ab7f84550993b44550879e10cd917b7bf02d04
> (2015-03-05) where support for multiline string literals was added, but
> the code expecting the strings to be exactly single-line was not updated.
>
> >> The bug was reported only recently, but it seems pretty annoying
> >> (infloop during indentation), and the fix is simple.
> >
> > Taken at face value, it doesn't look simple: you are switching from
> > using 2 elements of what syntax-ppss returns to a 3rd one. How do we
> > know this won't introduce other issues? Maybe if you describe the
> > logic of the change, I will agree with you.
>
> The purpose of the code is get out of the current literal. In the clause
> that was changes, to go to the beginning of the enclosing string.
>
> (goto-char (nth 8 parse)) is a reliable way to do that. The same
> function does that for comments anyway.
OK, please backport this.
Thanks.
next prev parent reply other threads:[~2019-02-02 7:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190201000223.22803.66102@vcs0.savannah.gnu.org>
[not found] ` <20190201000224.6638E20B45@vcs0.savannah.gnu.org>
2019-02-01 0:27 ` [Emacs-diffs] master b01a429: js--re-search-backward-inner: Fix infloop Dmitry Gutov
2019-02-01 7:28 ` Eli Zaretskii
2019-02-02 0:08 ` Dmitry Gutov
2019-02-02 7:31 ` Eli Zaretskii [this message]
2019-02-23 23:43 ` Dmitry Gutov
2019-02-24 3:36 ` Eli Zaretskii
2019-02-26 1:01 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83womiwsra.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.