From: Eli Zaretskii <eliz@gnu.org>
To: Alan Mackenzie <acm@muc.de>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: Questionable code in handling of wordend in the regexp engine in regex-emacs.c
Date: Fri, 01 Mar 2019 21:31:37 +0200 [thread overview]
Message-ID: <83woligzmu.fsf@gnu.org> (raw)
In-Reply-To: <20190301191607.GG5674@ACM> (message from Alan Mackenzie on Fri, 1 Mar 2019 19:16:07 +0000)
> Date: Fri, 1 Mar 2019 19:16:07 +0000
> Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
> From: Alan Mackenzie <acm@muc.de>
>
> + /* Check bytepos is not in the middle of a character. */
> + eassert (bytepos >= BUF_Z_BYTE (b)
> + || CHAR_HEAD_P (BUF_FETCH_BYTE (b, bytepos)));
LGTM.
> After configuring with --enable-checking and building, I tried make
> check. The tests errored out with this bytepos check three times. In:
>
> src/coding-tests.log
> lisp/epg-tests.log
> lisp/emacs-lisp/package-tests.log
>
> . Quite possibly there is just one bug here, but there might be two or
> three. I think it would be best to track it/them down before committing
> the change to marker.c.
I agree. Let me know if you need help with that.
Thanks.
next prev parent reply other threads:[~2019-03-01 19:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 16:45 Questionable code in handling of wordend in the regexp engine in regex-emacs.c Alan Mackenzie
2019-02-23 23:15 ` Stefan Monnier
2019-02-25 18:56 ` Alan Mackenzie
2019-02-25 19:18 ` Stefan Monnier
2019-03-01 11:10 ` Alan Mackenzie
2019-03-01 13:41 ` Stefan Monnier
2019-03-01 13:46 ` Eli Zaretskii
2019-03-01 14:14 ` Alan Mackenzie
2019-03-01 14:43 ` Eli Zaretskii
2019-03-01 14:58 ` Alan Mackenzie
2019-03-01 16:22 ` Eli Zaretskii
2019-03-01 16:38 ` Alan Mackenzie
2019-03-01 19:16 ` Alan Mackenzie
2019-03-01 19:31 ` Eli Zaretskii [this message]
2019-03-02 11:16 ` Alan Mackenzie
2019-03-02 12:18 ` Eli Zaretskii
2019-03-02 13:18 ` Alan Mackenzie
2019-03-02 13:37 ` Eli Zaretskii
2019-03-04 17:25 ` Eli Zaretskii
2019-03-05 10:51 ` Alan Mackenzie
2019-03-05 16:26 ` Eli Zaretskii
2019-03-02 12:21 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83woligzmu.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=acm@muc.de \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.