From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Fill column indicator functionality Date: Sat, 16 Mar 2019 14:40:53 +0200 Message-ID: <83wokzxa96.fsf@gnu.org> References: <20190312192017.fkfd4h5gsbdue5q3@Ergus> <83imwm3fxf.fsf@gnu.org> <20190313200225.dpqrw7xthkj47fqw@Ergus> <83bm2e35a1.fsf@gnu.org> <20190314030224.l5zseslncw3xc5ox@Ergus> <835zsm2c2s.fsf@gnu.org> <20190314165147.gmtwgzqaibwbzhbm@Ergus> <83r2b91flg.fsf@gnu.org> <20190314211313.giyz7p6jtmquabea@Ergus> <83bm2c1smi.fsf@gnu.org> <20190316093610.qcjqflorltiyn42a@Ergus> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="187467"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 16 13:47:20 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h58ie-000mgc-Du for ged-emacs-devel@m.gmane.org; Sat, 16 Mar 2019 13:47:20 +0100 Original-Received: from localhost ([127.0.0.1]:41584 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h58id-0003cP-9X for ged-emacs-devel@m.gmane.org; Sat, 16 Mar 2019 08:47:19 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38908) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h58hU-0003X6-Tb for emacs-devel@gnu.org; Sat, 16 Mar 2019 08:46:09 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58990) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h58cg-0007m3-HQ; Sat, 16 Mar 2019 08:41:11 -0400 Original-Received: from [176.228.60.248] (port=1566 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h58ce-0007QY-SV; Sat, 16 Mar 2019 08:41:09 -0400 In-reply-to: <20190316093610.qcjqflorltiyn42a@Ergus> (message from Ergus on Sat, 16 Mar 2019 10:36:10 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234211 Archived-At: > Date: Sat, 16 Mar 2019 10:36:10 +0100 > From: Ergus > Cc: emacs-devel@gnu.org > > I tried that solution (setting the :height attribute to 1.0 in the face > declaration) and it didn't work. Well, I'm not really surprised, it was a long shot. > I see that there is a calc_line_height_property; can we use that to > change the glyph. Maybe it is possible to implement a setter (equivalent > to get_it_property? I don't think I understand the proposal. calc_line_height_property is used to produce line-spacing, but I don't see how it could be used for enlarging the font, since AFAIK that can only be done via a face definition. > We can compare the line height with the it height and change it > temporarily to print the indicator? That won't help, because the code we are talking about doesn't draw anything, it just prepares the data structures for drawing. the actual drawing happens later, and it is terminal-dependent (for X, see xterm.c, the function x_draw_glyph_string_foreground, for example). I think, unless some clever idea comes up which will allow us to use an existing feature, we should for now leave this issue alone, because avoiding the gap between indicators when line height varies will probably require adding some display features, and the indicator display shouldn't be held off till we do.