From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Renaming non-X x_* identifiers Date: Tue, 16 Apr 2019 19:45:12 +0300 Message-ID: <83wojtgaqv.fsf@gnu.org> References: <87wokp4okn.fsf@gmail.com> <87d0men4jx.fsf@gmail.com> <83o95sisk7.fsf@gnu.org> <87mulcnui4.fsf@gmail.com> <83bm1si7lf.fsf@gnu.org> <87ef6ont03.fsf@gmail.com> <83a7hci44l.fsf@gnu.org> <87a7hcndtc.fsf@gmail.com> <831s2nhza8.fsf@gnu.org> <87d0lpvq6n.fsf_-_@gmail.com> <83r2a5keo7.fsf@gnu.org> <87pnppu4ox.fsf@gmail.com> <83muktk9xb.fsf@gnu.org> <875zrhtg2i.fsf@gmail.com> <83ftqkk7lr.fsf@gnu.org> <877ebwvatg.fsf@gmail.com> <83y34cin3g.fsf@gnu.org> <87y34ctrs1.fsf@gmail.com> <83h8azianr.fsf@gnu.org> <87r2a3jh5h.fsf@gmail.com> <83y34bgldk.fsf@gnu.org> <87k1ftdiky.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="8137"; mail-complaints-to="usenet@blaine.gmane.org" Cc: alan@idiocy.org, emacs-devel@gnu.org To: Alex Gramiak Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 16 18:46:24 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hGRE0-00020G-Kt for ged-emacs-devel@m.gmane.org; Tue, 16 Apr 2019 18:46:24 +0200 Original-Received: from localhost ([127.0.0.1]:39576 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGRDz-0000xV-Kg for ged-emacs-devel@m.gmane.org; Tue, 16 Apr 2019 12:46:23 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57014) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGRD3-0000vh-71 for emacs-devel@gnu.org; Tue, 16 Apr 2019 12:45:26 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52108) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGRCx-000156-Kn; Tue, 16 Apr 2019 12:45:23 -0400 Original-Received: from [176.228.60.248] (port=4766 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hGRCv-0001Jp-0B; Tue, 16 Apr 2019 12:45:17 -0400 In-reply-to: <87k1ftdiky.fsf@gmail.com> (message from Alex Gramiak on Tue, 16 Apr 2019 10:24:13 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235533 Archived-At: > From: Alex Gramiak > Cc: emacs-devel@gnu.org, alan@idiocy.org > Date: Tue, 16 Apr 2019 10:24:13 -0600 > > /* Multi-frame and mouse support hooks. */ > > /* Graphical window systems are expected to define all of the > following hooks with the possible exception of: > > * query_colors > * activate_menubar_hook > * change_tool_bar_height_hook > * set_bitmap_icon_hook > * buffer_flipping_unblocked_hook > > */ > > I also added a couple missing comments to query_frame_background_color > and implicit_set_name_hook: > > /* This hook is called to store the frame's background color into > BGCOLOR. */ > > /* This hook is called to set the name of the GUI window by redisplay > unless another name was explicitly requested. */ Sounds good enough, thanks. We can always add more later if needed.