From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35994: Remove leading '*' from defcustom docstring todo considered done Date: Sun, 09 Jun 2019 10:12:47 +0300 Message-ID: <83wohvb5ao.fsf@gnu.org> References: <87muj4btku.fsf@tcd.ie> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="91770"; mail-complaints-to="usenet@blaine.gmane.org" Cc: contovob@tcd.ie, 35994-done@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 09 09:14:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hZs1u-000Nj5-3S for geb-bug-gnu-emacs@m.gmane.org; Sun, 09 Jun 2019 09:14:14 +0200 Original-Received: from localhost ([::1]:34264 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZs1s-00060m-Eu for geb-bug-gnu-emacs@m.gmane.org; Sun, 09 Jun 2019 03:14:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43643) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZs1k-0005yk-JG for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2019 03:14:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hZs1i-0000mY-TD for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2019 03:14:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40612) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hZs1i-0000mK-LO for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2019 03:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hZs1i-0004Aq-FA for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2019 03:14:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Jun 2019 07:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 35994 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 35994@debbugs.gnu.org, eliz@gnu.org, stefan@marxist.se Original-Received: via spool by 35994-done@debbugs.gnu.org id=D35994.156006438515959 (code D ref 35994); Sun, 09 Jun 2019 07:14:02 +0000 Original-Received: (at 35994-done) by debbugs.gnu.org; 9 Jun 2019 07:13:05 +0000 Original-Received: from localhost ([127.0.0.1]:54155 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZs0n-00049K-97 for submit@debbugs.gnu.org; Sun, 09 Jun 2019 03:13:05 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZs0l-00048n-T9 for 35994-done@debbugs.gnu.org; Sun, 09 Jun 2019 03:13:04 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56000) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hZs0d-0008Gn-Gv; Sun, 09 Jun 2019 03:12:56 -0400 Original-Received: from [176.228.60.248] (port=3383 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hZs0c-0005rd-0K; Sun, 09 Jun 2019 03:12:54 -0400 In-reply-to: (message from Stefan Kangas on Mon, 3 Jun 2019 02:43:59 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160260 Archived-At: > From: Stefan Kangas > Date: Mon, 3 Jun 2019 02:43:59 +0200 > Cc: 35994@debbugs.gnu.org > > Basil L. Contovounesios writes: > > There is also at least one defface (ibuffer-locked-buffer), and the > > Please find attached an updated patch fixing this - thanks. > > > defvars in lisp/obsolete/cc-compat.el (I just did a quick rgrep '^ "\*'). > > This is related to the TODO: > > ** Convert all defvars with leading '*' in the doc-strings into defcustoms > of appropriate :type and :group. > > I have attached a second patch which fixes this TODO item. Thanks, I pushed this to the master branch. Please in the future, if you send several patches that change the same files, be sure to arrange them in the order you made the changes, because otherwise they might fail to apply. In this case you sent the patches in the reverse order; I was lucky to be able to figure out that they need to be applied in reverse. (In general, if you change the same files for reasons that are closely related, like in this case, sending a single patch makes the job of installing easier.)