all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: contovob@tcd.ie, 35994-done@debbugs.gnu.org
Subject: bug#35994: Remove leading '*' from defcustom docstring todo considered done
Date: Sun, 09 Jun 2019 10:12:47 +0300	[thread overview]
Message-ID: <83wohvb5ao.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmmL+-04mgc1LxsrWQQ-_90xQV28DHC1CrxGp1gFtytjmw@mail.gmail.com> (message from Stefan Kangas on Mon, 3 Jun 2019 02:43:59 +0200)

> From: Stefan Kangas <stefan@marxist.se>
> Date: Mon, 3 Jun 2019 02:43:59 +0200
> Cc: 35994@debbugs.gnu.org
> 
> Basil L. Contovounesios <contovob@tcd.ie> writes:
> > There is also at least one defface (ibuffer-locked-buffer), and the
> 
> Please find attached an updated patch fixing this - thanks.
> 
> > defvars in lisp/obsolete/cc-compat.el (I just did a quick rgrep '^  "\*').
> 
> This is related to the TODO:
> 
>  ** Convert all defvars with leading '*' in the doc-strings into defcustoms
>   of appropriate :type and :group.
> 
> I have attached a second patch which fixes this TODO item.

Thanks, I pushed this to the master branch.

Please in the future, if you send several patches that change the same
files, be sure to arrange them in the order you made the changes,
because otherwise they might fail to apply.  In this case you sent the
patches in the reverse order; I was lucky to be able to figure out
that they need to be applied in reverse.

(In general, if you change the same files for reasons that are closely
related, like in this case, sending a single patch makes the job of
installing easier.)





      reply	other threads:[~2019-06-09  7:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-29 17:55 bug#35994: Remove leading '*' from defcustom docstring todo considered done Stefan Kangas
2019-05-30  1:48 ` Basil L. Contovounesios
2019-06-03  0:43   ` Stefan Kangas
2019-06-09  7:12     ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83wohvb5ao.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=35994-done@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.