From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Tabs Date: Tue, 03 Sep 2019 05:27:31 +0300 Message-ID: <83woeq6rn0.fsf@gnu.org> References: <87a7bpysm8.fsf@mail.linkov.net> <87o903dc2j.fsf@mail.linkov.net> <831rwz8m7n.fsf@gnu.org> <87h85ubioc.fsf@mail.linkov.net> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="101147"; mail-complaints-to="usenet@blaine.gmane.org" Cc: rudalics@gmx.at, emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 03 04:27:48 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i4yXs-000QDR-8v for ged-emacs-devel@m.gmane.org; Tue, 03 Sep 2019 04:27:48 +0200 Original-Received: from localhost ([::1]:40952 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i4yXr-0001YI-7D for ged-emacs-devel@m.gmane.org; Mon, 02 Sep 2019 22:27:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49231) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i4yXl-0001YB-9x for emacs-devel@gnu.org; Mon, 02 Sep 2019 22:27:42 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44922) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i4yXk-0000W9-Lh; Mon, 02 Sep 2019 22:27:40 -0400 Original-Received: from [176.228.60.248] (port=4446 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i4yXj-0001SX-DP; Mon, 02 Sep 2019 22:27:40 -0400 In-reply-to: <87h85ubioc.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 02 Sep 2019 22:29:55 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239792 Archived-At: > From: Juri Linkov > Cc: rudalics@gmx.at, emacs-devel@gnu.org > Date: Mon, 02 Sep 2019 22:29:55 +0300 > > >> > To make your branch build on Windows you need to install the attached > >> > patch at least (blindly copied from its X counterparts). Therafter, > >> > Emacs builds and comes up normally. > >> > >> Thanks, I pushed your patch to the branch. I hope it would be possible > >> to do refactoring on top of your patch to avoid duplicating GUI code > >> like Eli asked. > > > > I think such refactoring should be done before the branch is merged. > > I gather this is opportunity for refactoring of tool-bar code as well. Could be, yes. Although the tool bar is already implemented via frame-type specific hooks, so some of that work has been done already.