From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Severe regressions in context of keyboard macros Date: Tue, 24 Sep 2019 11:45:35 +0300 Message-ID: <83wodynkuo.fsf@gnu.org> References: <83a7aztoq9.fsf@gnu.org> <6b147564-cfea-1824-701f-33495958d304@web.de> <83d0fusvjd.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="234044"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Christoph Arenz Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 24 10:51:52 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iCgY2-000yh5-O9 for ged-emacs-devel@m.gmane.org; Tue, 24 Sep 2019 10:51:50 +0200 Original-Received: from localhost ([::1]:42690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCgY0-0003k8-BP for ged-emacs-devel@m.gmane.org; Tue, 24 Sep 2019 04:51:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49431) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCgSG-0001no-UB for emacs-devel@gnu.org; Tue, 24 Sep 2019 04:45:54 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37730) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iCgSF-0006lX-8P; Tue, 24 Sep 2019 04:45:51 -0400 Original-Received: from [176.228.60.248] (port=3339 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iCgSE-0007vI-7y; Tue, 24 Sep 2019 04:45:50 -0400 In-reply-to: (message from Christoph Arenz on Mon, 23 Sep 2019 13:57:00 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240272 Archived-At: > Cc: emacs-devel@gnu.org > From: Christoph Arenz > Date: Mon, 23 Sep 2019 13:57:00 +0200 > > How about the following patch? It solved the calc bug for me and I could not find other regressions so far. > Running make check showed no difference. > As mentioned, I do not understand all potential effects, so it should be given some thoughts and tests. Thanks, but I'd like to avoid changes in keyboard.c on behalf of input recording issues, unless such changes are really a must. In this case, we already have 2 facilities to deal with unwanted repeated recording of keys: . a Lisp program can bind inhibit--record-char to a non-nil value to avoid recording input events while some Lisp form is executed (you can see an example of using this in quail.el:quail-start-translation . a Lisp program can push onto unread-command-events a cons cell of the form '(no-record . KEY) to avoid recording KEY more than once (you can see an example of using this in cua-base.el:cua--prefix-override-replay) Can you use one of these facilities to solve the issue in Calc? Note that you will need to build Emacs from the Git master branch to be able to use these facilities, they are not available before Emacs 27. Thanks.