Make bootsrap failure -- tab-bar.el

Make bootsrap failure -- tab-bar.el

[Michael Mauger]

Let me know if I'm just insane...

On a clean checkout of master, I do:

    $ make -j6 bootstrap
    ...
    LC_ALL=C ./temacs -batch  -l loadup --temacs=pdump
    Loading loadup.el (source)...
    dump mode: pdump
    Using load-path (/home/michael/devel/emacs/master/lisp)
    Loading emacs-lisp/byte-run...
    Loading emacs-lisp/backquote...
    Loading subr...
    ...
    Loading menu-bar...
    Loading tab-bar.el (source)...
    Eager macro-expansion failure: (error "(require cl-lib) while preparing to dump")
    Eager macro-expansion failure: (error "(require cl-lib) while preparing to dump")
    (require cl-lib) while preparing to dump
    make[2]: *** [Makefile:584: emacs.pdmp] Error 255

Is there a reason I'm the only one seeing this.

TIA
--
MICHAEL@MAUGER.COM // FSF and EFF member // GNU Emacs sql.el maintainer

Re: Make bootsrap failure -- tab-bar.el

[Juri Linkov]

> Let me know if I'm just insane...
>
> On a clean checkout of master, I do:
>
>     $ make -j6 bootstrap
>     ...
>     LC_ALL=C ./temacs -batch  -l loadup --temacs=pdump
>     Loading loadup.el (source)...
>     dump mode: pdump
>     Using load-path (/home/michael/devel/emacs/master/lisp)
>     Loading emacs-lisp/byte-run...
>     Loading emacs-lisp/backquote...
>     Loading subr...
>     ...
>     Loading menu-bar...
>     Loading tab-bar.el (source)...
>     Eager macro-expansion failure: (error "(require cl-lib) while preparing to dump")
>     Eager macro-expansion failure: (error "(require cl-lib) while preparing to dump")
>     (require cl-lib) while preparing to dump
>     make[2]: *** [Makefile:584: emacs.pdmp] Error 255
>
> Is there a reason I'm the only one seeing this.

This is strange indeed.  I tried to bootstrap on a clean checkout of master,
and there are no errors.

Re: Make bootsrap failure -- tab-bar.el

[Juri Linkov]

> Let me know if I'm just insane...
>
> On a clean checkout of master, I do:
>
>     $ make -j6 bootstrap
>     ...
>     LC_ALL=C ./temacs -batch  -l loadup --temacs=pdump
>     Loading loadup.el (source)...
>     dump mode: pdump
>     Using load-path (/home/michael/devel/emacs/master/lisp)
>     Loading emacs-lisp/byte-run...
>     Loading emacs-lisp/backquote...
>     Loading subr...
>     ...
>     Loading menu-bar...
>     Loading tab-bar.el (source)...
>     Eager macro-expansion failure: (error "(require cl-lib) while preparing to dump")
>     Eager macro-expansion failure: (error "(require cl-lib) while preparing to dump")
>     (require cl-lib) while preparing to dump
>     make[2]: *** [Makefile:584: emacs.pdmp] Error 255
>
> Is there a reason I'm the only one seeing this.

Now I got exactly the same error when edited and saved the source file
tab-bar.el during compilation.  Here is the difference.

* Normal compilation log:

Loading menu-bar...
Loading tab-bar...

* When touching the source file during compilation:

Loading menu-bar...
Loading tab-bar.el (source)...
Eager macro-expansion failure: (error "(require cl-lib) while preparing to dump")
Eager macro-expansion failure: (error "(require cl-lib) while preparing to dump")
(require cl-lib) while preparing to dump
Makefile:584: recipe for target 'emacs.pdmp' failed

Note how it tries to load the source file tab-bar.el
instead of loading the compiled file tab-bar.elc.

This is because the dumper sets 'load-prefer-newer' to 't'.

Re: Make bootsrap failure -- tab-bar.el

[Eli Zaretskii]

> From: Juri Linkov <juri@linkov.net>
> Date: Wed, 16 Oct 2019 20:48:05 +0300
> Cc: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
> 
> Now I got exactly the same error when edited and saved the source file
> tab-bar.el during compilation.

Don't do that.

Re: Make bootsrap failure -- tab-bar.el

[Michael Mauger]

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Wednesday, October 16, 2019 2:48 PM, Eli Zaretskii <eliz@gnu.org> wrote:

> > From: Juri Linkov juri@linkov.net
>
> > Date: Wed, 16 Oct 2019 20:48:05 +0300
> > Cc: "emacs-devel@gnu.org" emacs-devel@gnu.org
> > Now I got exactly the same error when edited and saved the source file
> > tab-bar.el during compilation.
>

"Doctor, doctor! It hurts when I do this!"

> Don't do that.

:D

I'm doing the `git pull' followed by `autogen.sh' and `make bootstrap' and running into the issue; I'm never touching any files in-between. Also I'm not seeing the compiled version of tab-bar in the build tree. It feels like there is some artifact being left around that is skipping the compile of tab-bar. I've got to do a deeper dive into this to figure out where its happening.

I've got a separate checkout of master that I've used the same build script on and was able to build. So at least I have a recent build but that old master branch checkout is still broken.

I'll report back if I find something that could be an issue for others...
--
MICHAEL@MAUGER.COM // FSF and EFF member // GNU Emacs sql.el maintainer