From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: master 270ca8c: Fix internal-lisp-face-attributes to match face.
Date: Sun, 20 Oct 2019 19:08:48 +0300
Message-ID: <83wocz4cxb.fsf@gnu.org>
References: <20191020144609.32634.23000@vcs0.savannah.gnu.org>
 <20191020144611.3484F20BBC@vcs0.savannah.gnu.org> <87eez7toah.fsf@gmx.net>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="41456"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: spacibba@aol.com, emacs-devel@gnu.org
To: Stephen Berman <stephen.berman@gmx.net>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 20 18:09:09 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1iMDlV-000Af1-9M
	for ged-emacs-devel@m.gmane.org; Sun, 20 Oct 2019 18:09:09 +0200
Original-Received: from localhost ([::1]:39820 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1iMDlT-000638-HK
	for ged-emacs-devel@m.gmane.org; Sun, 20 Oct 2019 12:09:07 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59710)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>) id 1iMDlJ-00062x-99
 for emacs-devel@gnu.org; Sun, 20 Oct 2019 12:08:58 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50247)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
 id 1iMDlI-0004lt-Re; Sun, 20 Oct 2019 12:08:56 -0400
Original-Received: from [176.228.60.248] (port=2196 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1iMDlH-0004Qm-Od; Sun, 20 Oct 2019 12:08:56 -0400
In-reply-to: <87eez7toah.fsf@gmx.net> (message from Stephen Berman on Sun, 20
 Oct 2019 17:44:06 +0200)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:241251
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/241251>

> From: Stephen Berman <stephen.berman@gmx.net>
> Date: Sun, 20 Oct 2019 17:44:06 +0200
> Cc: Jimmy Aguilar Mena <spacibba@aol.com>
> 
> >     * lisp/face-remap.el (internal-lisp-face-attributes): Updated the
>                                                             ^^^^^^^
> 
> The conventional practice is to use the imperative form of verbs in
> commit messages (so here "Update").  (I couldn't find documentation of
> this practice

Because there's nothing wrong with "Updated", IMO.  You will find, for
example, "Function removed" and the likes in the logs.