From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#39491: 28.0.50; two bugs in battery-upower Date: Sun, 26 Apr 2020 17:47:21 +0300 Message-ID: <83wo625mo6.fsf@gnu.org> References: <83mu9tedsh.fsf@gnu.org> <5A4C6466-FB4B-484F-BF29-91762AFB46F3@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="29603"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39491@debbugs.gnu.org, rms@gnu.org, monnier@iro.umontreal.ca To: lg.zevlg@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 26 16:48:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jSiZm-0007b0-Jm for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Apr 2020 16:48:10 +0200 Original-Received: from localhost ([::1]:60878 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSiZl-0005L9-AM for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Apr 2020 10:48:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60610) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSiZe-0005Kw-SB for bug-gnu-emacs@gnu.org; Sun, 26 Apr 2020 10:48:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jSiZe-0002lo-FJ for bug-gnu-emacs@gnu.org; Sun, 26 Apr 2020 10:48:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50578) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jSiZe-0002kW-38 for bug-gnu-emacs@gnu.org; Sun, 26 Apr 2020 10:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jSiZe-0001Un-12 for bug-gnu-emacs@gnu.org; Sun, 26 Apr 2020 10:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Apr 2020 14:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39491 X-GNU-PR-Package: emacs Original-Received: via spool by 39491-submit@debbugs.gnu.org id=B39491.15879124625723 (code B ref 39491); Sun, 26 Apr 2020 14:48:01 +0000 Original-Received: (at 39491) by debbugs.gnu.org; 26 Apr 2020 14:47:42 +0000 Original-Received: from localhost ([127.0.0.1]:33891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSiZK-0001UF-0X for submit@debbugs.gnu.org; Sun, 26 Apr 2020 10:47:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSiZJ-0001RI-Du for 39491@debbugs.gnu.org; Sun, 26 Apr 2020 10:47:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44030) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSiZD-0001tx-MJ; Sun, 26 Apr 2020 10:47:35 -0400 Original-Received: from [176.228.60.248] (port=2402 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jSiZ6-0001do-4e; Sun, 26 Apr 2020 10:47:28 -0400 In-Reply-To: <5A4C6466-FB4B-484F-BF29-91762AFB46F3@gmail.com> (lg.zevlg@gmail.com) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179071 Archived-At: > From: lg.zevlg@gmail.com > Date: Sat, 8 Feb 2020 12:10:46 +0400 > Cc: 39491@debbugs.gnu.org, rms@gnu.org, > Stefan Monnier > > >> However, that function has a design flaw: it reports on just the first > >> battery in the list. battery-upower-device-list correctly returns a > >> list with an element for each battery, but battery-upower finds only one > >> of them (the first one in the list) and ignores the others. > >> > >> The old code handle all the batteries and added the energy quantities > >> so as to report accurately the total power available and overall > >> fraction of charge. I wrote that code myself, around 10 years ago. > >> > >> Please restore the lost functionality. > > > > Evgeny, could you please look into fixing this? > > > > OK, we should generalize multi-battery code then, so each status func won’t reimplement multi battery handling. > > I’ll look at it tomorrow Evgeny, any progress in fixing this? TIA