bug#41285: 28.0.50; bibtex-Book not defined

bug#41285: 28.0.50; bibtex-Book not defined

[Shuguang Sun]

Dear,

When I run bibtex-Book (C-c C-e b) in bibtex-mode buffer, it is said
"command-execute: Wrong type argument: commandp, bibtex-Book".
I think it happened after 	6bcf7912aad6312d4bd521a3b8b5d9638d83dfa1 (patch), where it uses defalias to replace defun.

BR
Shuguang Sun



In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.20, cairo version 1.17.3)
 of 2020-05-15 built on lilydjwg
Repository revision: 779bc886f9bc2e3188bf2577c3df2ae662ca1b98
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12008000
System Description: Manjaro Linux

bug#41285: 28.0.50; bibtex-Book not defined

[Shuguang Sun]

[-- Attachment #1: Type: text/plain, Size: 943 bytes --]

Hi,

It looks like the enclosing of the defalias and lamba is wrong. The body of th lambda is enclosed in the document.

Patch attached. Please review.

BR
Shuguang Sun


------------------ Original ------------------
Date: Fri, May 15, 2020 08:25 PM
To: "bug-gnu-emacs"<bug-gnu-emacs@gnu.org>;

Subject: 28.0.50; bibtex-Book not defined



Dear,

When I run bibtex-Book (C-c C-e b) in bibtex-mode buffer, it is said
"command-execute: Wrong type argument: commandp, bibtex-Book".
I think it happened after 	6bcf7912aad6312d4bd521a3b8b5d9638d83dfa1 (patch), where it uses defalias to replace defun.

BR
Shuguang Sun



In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.20, cairo version 1.17.3)
 of 2020-05-15 built on lilydjwg
Repository revision: 779bc886f9bc2e3188bf2577c3df2ae662ca1b98
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12008000
System Description: Manjaro Linux

[-- Attachment #2: bibtex_book-entry_bracket.diff --]
[-- Type: application/octet-stream, Size: 832 bytes --]

warning: LF will be replaced by CRLF in lisp/textmodes/bibtex.el.
The file will have its original line endings in your working directory
diff --git a/lisp/textmodes/bibtex.el b/lisp/textmodes/bibtex.el
index fa82227f36..63abd19b6d 100644
--- a/lisp/textmodes/bibtex.el
+++ b/lisp/textmodes/bibtex.el
@@ -3559,9 +3559,9 @@ bibtex-set-dialect
               (lambda ()
                 (:documentation
                  (format "Insert a template for a @%s entry; see also `bibtex-entry'."
-                         entry)
+                         entry))
                  (interactive "*")
-                 (bibtex-entry entry)))))
+                 (bibtex-entry entry))))
           ;; Menu entries
           (define-key menu-map (vector fname)
             `(menu-item ,(or (nth 1 elt) (car elt)) ,fname))))

bug#41285: 28.0.50; bibtex-Book not defined

[Eli Zaretskii]

> From: "Shuguang Sun" <shuguang79@qq.com>
> Date: Sat, 16 May 2020 10:22:43 +0800
> 
> It looks like the enclosing of the defalias and lamba is wrong. The body of th lambda is enclosed in the document.
> 
> Patch attached. Please review.

CC'ing Stefan, who made that change.

bug#41285: 28.0.50; bibtex-Book not defined

[Stefan Monnier]

>> It looks like the enclosing of the defalias and lamba is wrong. The body
>> of th lambda is enclosed in the document.
>> 
>> Patch attached. Please review.
>
> CC'ing Stefan, who made that change.

Should be fixed now,


        Stefan

bug#41285: 28.0.50; bibtex-Book not defined

[Andreas Schwab]

On Mai 16 2020, Shuguang Sun wrote:

> --- a/lisp/textmodes/bibtex.el
> +++ b/lisp/textmodes/bibtex.el
> @@ -3559,9 +3559,9 @@ bibtex-set-dialect
>                (lambda ()
>                  (:documentation
>                   (format "Insert a template for a @%s entry; see also `bibtex-entry'."
> -                         entry)
> +                         entry))
>                   (interactive "*")
> -                 (bibtex-entry entry)))))
> +                 (bibtex-entry entry))))

This makes the indentation disagreeing with the nesting.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."