From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#42386: Acknowledgement ([PATCH] Handle symbols in project-kill-buffers-ignores) Date: Thu, 16 Jul 2020 22:35:24 +0300 Message-ID: <83wo33jls3.fsf@gnu.org> References: <877dv3uxyv.fsf@warpmail.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29589"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 42386@debbugs.gnu.org To: "Philip K." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 16 21:36:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jw9fw-0007bR-RO for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Jul 2020 21:36:12 +0200 Original-Received: from localhost ([::1]:55008 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jw9fv-0004aX-Ew for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Jul 2020 15:36:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47548) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jw9fn-0004aL-ML for bug-gnu-emacs@gnu.org; Thu, 16 Jul 2020 15:36:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44499) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jw9fm-0001ti-DP for bug-gnu-emacs@gnu.org; Thu, 16 Jul 2020 15:36:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jw9fm-000617-9x for bug-gnu-emacs@gnu.org; Thu, 16 Jul 2020 15:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Jul 2020 19:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42386 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 42386-submit@debbugs.gnu.org id=B42386.159492814823107 (code B ref 42386); Thu, 16 Jul 2020 19:36:02 +0000 Original-Received: (at 42386) by debbugs.gnu.org; 16 Jul 2020 19:35:48 +0000 Original-Received: from localhost ([127.0.0.1]:56045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw9fY-00060d-0f for submit@debbugs.gnu.org; Thu, 16 Jul 2020 15:35:48 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw9fV-00060O-ED for 42386@debbugs.gnu.org; Thu, 16 Jul 2020 15:35:46 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54191) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jw9fQ-0001mV-2B; Thu, 16 Jul 2020 15:35:40 -0400 Original-Received: from [176.228.60.248] (port=2041 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jw9fO-0001Nz-RY; Thu, 16 Jul 2020 15:35:39 -0400 In-Reply-To: <877dv3uxyv.fsf@warpmail.net> (philip@warpmail.net) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:183113 Archived-At: > From: "Philip K." > Cc: 42386@debbugs.gnu.org > Date: Thu, 16 Jul 2020 20:16:40 +0200 > > > And why do you require a function not to be a symbol? I'm probably > > missing something. > > My idea was to only allow lambda expressions, but that would make it > hard to implement more complex predicates that should be defined in > their own defuns. Right, I don't think we should disallow named functions. > How about this: Instead of symbols, adding a cons-cell: > > (major-mode . erc-mode) > > prevents erc-buffers from being killed? You are trying to separate modes from other functions? Why? Just see if the major-mode's symbol is in the list, and if so, spare the buffer. Otherwise, if it's a function, call that function assuming it's a predicate. Does this present some problems?