From: Eli Zaretskii <eliz@gnu.org>
To: Pierre Rouleau <prouleau001@gmail.com>
Cc: 44494@debbugs.gnu.org, dgutov@yandex.ru
Subject: bug#44494: etags.el xref-location-marker does not handle TAGS references to .el.gz files
Date: Sat, 07 Nov 2020 10:00:33 +0200 [thread overview]
Message-ID: <83wnyx7g0u.fsf@gnu.org> (raw)
In-Reply-To: <CALTqLiZtHEjtHB7BGKuFknKDLgNvpbjDkfNhoK9pLFi7k2LYxQ@mail.gmail.com> (message from Pierre Rouleau on Fri, 6 Nov 2020 22:31:02 -0500)
> From: Pierre Rouleau <prouleau001@gmail.com>
> Date: Fri, 6 Nov 2020 22:31:02 -0500
> Cc: 44494@debbugs.gnu.org
>
> Do you see the same problem with 'M-x find-tag'?
>
> Short answer: yes
>
> Longer answer: you can try it on Emacs lib files.
>
> For example, I created a TAGS file that contains the following:
>
> define-globalized-minor-mode global-prettify-symbols-mode^?247,10355
> (define-derived-mode prog-mode ^?251,10485
> ^L
> /usr/local/Cellar/emacs/26.3/share/emacs/26.3/lisp/progmodes/cc-bytecomp.el,1014
> (defvar cc-bytecomp-unbound-variables ^?76,2968
> (defvar cc-bytecomp-original-functions ^?77,3011
> (defvar cc-bytecomp-original-properties ^?78,3055
> (defvar cc-bytecomp-loaded-files ^?79,3100
> (defvar cc-bytecomp-environment-set ^?86,3302
> (defmacro cc-bytecomp-debug-msg ^?88,3344
> (defun cc-bytecomp-compiling-or-loading ^?93,3432
> (defsubst cc-bytecomp-is-compiling ^?134,4714
> (defsubst cc-bytecomp-is-loading ^?138,4857
> (defun cc-bytecomp-setup-environment ^?143,5065
> (defun cc-bytecomp-restore-environment ^?191,6703
> (defun cc-bytecomp-load ^?256,8749
> (defmacro cc-require ^?293,10222
> (defmacro cc-conditional-require ^?305,10617
> (defmacro cc-conditional-require-after-load ^?318,11068
> (defmacro cc-provide ^?333,11627
> (defmacro cc-load ^?340,11887
> (defmacro cc-require-when-compile ^?351,12266
> (defmacro cc-external-require ^?362,12703
> (defmacro cc-bytecomp-defvar ^?371,13055
> (defmacro cc-bytecomp-defun ^?392,13857
> (defmacro cc-bytecomp-put ^?419,14990
> (defmacro cc-bytecomp-boundp ^?437,15739
> (defmacro cc-bytecomp-fboundp ^?447,16140
> ^L
> /usr/local/Cellar/emacs/26.3/share/emacs/26.3/lisp/progmodes/make-mode.el,6494
> (defgroup makefile ^?95,3661
> (defface makefile-space^?101,3839
> (defface makefile-targets^?107,4026
> (defface makefile-shell^?114,4302
>
> Then with the file /usr/local/Cellar/emacs/26.3/share/emacs/26.3/lisp/progmodes/cc-cmds.el.gz in a buffer
> and cc-bytecomp not loaded trying both
>
> M-x xref-find-definitions cc-require
>
> and
>
> M-x find-tag cc-require
>
> I get:
>
> Rerun etags: ‘^(defmacro cc-require ’ not found in
> /usr/local/Cellar/emacs/26.3/share/emacs/26.3/lisp/progmodes/cc-bytecomp.el
I cannot reproduce this: find-tag works in this situation, at least in
the current emacs-27 branch and in stock Emacs 27.1. Which doesn't
surprise me, since etags.el already has code that handles compressed
files.
Moreover, M-. (which uses xref) works as well. So I'm no longer sure
I understand what is the problem you are seeing. If you see this in
Emacs 26, please retry in Emacs 27, and let's take this from there.
FTR, the steps I used for reproducing were slightly different:
. "make TAGS" in the top-level directory of the Emacs source tree
. gzip lisp/abbrevs.el
. emacs -Q
. C-x C-f lisp/simple.el
. C-u M-. kill-all-abbrevs RET
And for find-tag, replace the last 2 commands with
. M-x visit-tags-table RET RET
. M-x find-tag RET kill-all-abbrevs RET
Both of these work and show abbrevs.el.gz at the correct line.
next prev parent reply other threads:[~2020-11-07 8:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 23:22 bug#44494: etags.el xref-location-marker does not handle TAGS references to .el.gz files Pierre Rouleau
2020-11-07 2:22 ` Dmitry Gutov
2020-11-07 3:31 ` Pierre Rouleau
2020-11-07 8:00 ` Eli Zaretskii [this message]
2020-11-07 14:15 ` Pierre Rouleau
2020-11-07 14:22 ` Eli Zaretskii
2020-11-07 14:37 ` Eli Zaretskii
2020-11-07 14:48 ` Pierre Rouleau
2020-11-07 15:39 ` Pierre Rouleau
2020-11-07 15:52 ` Eli Zaretskii
2020-11-07 16:09 ` Pierre Rouleau
2020-11-07 7:18 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wnyx7g0u.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=44494@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=prouleau001@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.