all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tassilo Horn <tsdh@gnu.org>
Cc: 48404@debbugs.gnu.org, stefan@marxist.se
Subject: bug#48404: 28.0.50; "Invalid version syntax" errors with read-extended-command
Date: Fri, 14 May 2021 09:21:03 +0300	[thread overview]
Message-ID: <83wns1zvhs.fsf@gnu.org> (raw)
In-Reply-To: <875yzms6im.fsf@gnu.org> (message from Tassilo Horn on Thu, 13 May 2021 22:45:01 +0200)

> From: Tassilo Horn <tsdh@gnu.org>
> Date: Thu, 13 May 2021 22:45:01 +0200
> Cc: Stefan Kangas <stefan@marxist.se>
> 
> Since commit 1af91d271e077134e272055407fb8c4312a7579b I get strange
> "Invalid version syntax: <package> <version> (must start with a number)"
> errors during M-x completion in the minibuffer.  I can't reproduce with
> emacs -Q but in the error, <package> is always some (M)ELPA package.
> 
> For example, M-x mag TAB gives
> 
>   completion--some: Invalid version syntax: ‘Magit 3.0.0’ (must start with a number)

That commit uses byte-obsolete-info property of a symbol, and expects
its caddr to be a valid version number.  It sounds like in some cases
it is not an Emacs version, but something else.  So, questions:

  . can you find out what kind of value does the byte-obsolete-info
    property is there on Magit functions? and
  . how come these properties were added to something that is not an
    Emacs core code?

In any case, it sounds like blindly trusting the value of that
property is not a good idea, and we should wrap the call to
version-to-list there in condition-case.  Could you try that?





  reply	other threads:[~2021-05-14  6:21 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-13 20:45 bug#48404: 28.0.50; "Invalid version syntax" errors with read-extended-command Tassilo Horn
2021-05-14  6:21 ` Eli Zaretskii [this message]
2021-05-14  6:47   ` Tassilo Horn
2021-05-14  7:18     ` Eli Zaretskii
2021-05-14  7:28       ` Eli Zaretskii
2021-05-14  7:43       ` Lars Ingebrigtsen
2021-05-14  7:56         ` Eli Zaretskii
2021-05-16 14:06           ` Lars Ingebrigtsen
2021-05-16 14:27             ` Eli Zaretskii
2021-05-16 14:38               ` Lars Ingebrigtsen
2021-05-16 14:48                 ` Eli Zaretskii
2021-05-17 13:54                   ` Lars Ingebrigtsen
2021-05-17 14:10                     ` Eli Zaretskii
2021-05-17 14:20                       ` Lars Ingebrigtsen
2021-05-17 14:27                         ` Eli Zaretskii
2021-05-18 13:31                           ` Lars Ingebrigtsen
2021-05-19 11:54                         ` Tassilo Horn
2021-05-19 13:59                           ` Eli Zaretskii
2021-05-14  7:41     ` Lars Ingebrigtsen
2021-05-14 16:45   ` Stefan Kangas
2021-05-14 16:51     ` Lars Ingebrigtsen
2021-05-14  7:50 ` bug#48404: Daniel Mendler
2021-05-14 18:31 ` bug#48404: Daniel Mendler
2021-05-16 14:09   ` bug#48404: Lars Ingebrigtsen
2021-05-16 20:26     ` bug#48404: Daniel Mendler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83wns1zvhs.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=48404@debbugs.gnu.org \
    --cc=stefan@marxist.se \
    --cc=tsdh@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.