From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master b72f885: Make dlet work like let, not let* Date: Sun, 01 Aug 2021 19:10:10 +0300 Message-ID: <83wnp5m9i5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19266"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= , Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 01 18:11:26 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mAE3h-0004qs-OW for ged-emacs-devel@m.gmane-mx.org; Sun, 01 Aug 2021 18:11:25 +0200 Original-Received: from localhost ([::1]:45904 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mAE3g-0003O6-Jw for ged-emacs-devel@m.gmane-mx.org; Sun, 01 Aug 2021 12:11:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45642) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mAE2m-00020t-7t for emacs-devel@gnu.org; Sun, 01 Aug 2021 12:10:28 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47982) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mAE2k-0005Wn-HD; Sun, 01 Aug 2021 12:10:26 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2645 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mAE2j-0005Wq-NY; Sun, 01 Aug 2021 12:10:26 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271918 Archived-At: > branch: master > commit b72f88518b89560accf740a4548368863e6238e0 > Author: Mattias Engdegård > Commit: Mattias Engdegård > > Make dlet work like let, not let* > > Change `dlet` so that it has binding semantics like `let` because that > is what a user would expect and it allows a corresponding `dlet*` to > be added later should the need arise. Fortunately the change has no > effect where it is currently used. > > * lisp/subr.el (dlet): Work like let. > * lisp/calendar/cal-bahai.el (calendar-bahai-date-string): > * lisp/calendar/cal-coptic.el (calendar-coptic-date-string): > * lisp/calendar/cal-dst.el (calendar-time-zone-daylight-rules) > (calendar-dst-starts, dst-in-effect): > * lisp/calendar/cal-persia.el (calendar-persian-date-string): > * lisp/calendar/calendar.el (calendar-dlet, calendar-generate-month) > (calendar-update-mode-line, calendar-date-string): > * lisp/calendar/diary-lib.el (diary-list-entries-2) > (diary-list-entries, diary-mark-entries-1, diary-sexp-entry) > (diary-remind, diary-font-lock-date-forms, diary-fancy-date-pattern): > * lisp/calendar/holidays.el (holiday-sexp): > * lisp/calendar/icalendar.el (icalendar--convert-float-to-ical): > * lisp/calendar/solar.el (solar-time-string): > * lisp/calendar/todo-mode.el (todo-date-pattern) > (todo-edit-item--header, todo-convert-legacy-date-time) > (todo-read-date): > Rename `calendar-dlet*` to `calendar-dlet` since it uses `dlet`. Why is this change a good idea? We had 'dlet' since more than a year ago, so the ship has sailed quite some time ago, I'd say.