From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: PR: dired-do-create-files now checks for trailing slashes in the target Date: Thu, 30 Sep 2021 19:03:32 +0300 Message-ID: <83wnmyf3u3.fsf@gnu.org> References: <831r58k0cx.fsf@gnu.org> <87tui4qyni.fsf@gnu.org> <83tui4iift.fsf@gnu.org> <874ka43rp1.fsf@gnu.org> <83ee97il43.fsf@gnu.org> <87zgrv33mf.fsf@gnu.org> <838rzfijnj.fsf@gnu.org> <87r1d73312.fsf@gnu.org> <837deziiwz.fsf@gnu.org> <87ee97bgxt.fsf@gnus.org> <87fstn2ydc.fsf@gnu.org> <87bl4a7g2m.fsf@gnus.org> <87sfxmqwdr.fsf@gnu.org> <87bl4a2nng.fsf@gnus.org> <87lf3ew3k5.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35393"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, stefankangas@gmail.com, rudiwillalwaysloveyou@gmail.com, emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 30 18:30:33 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mVyx6-0008xo-Rr for ged-emacs-devel@m.gmane-mx.org; Thu, 30 Sep 2021 18:30:32 +0200 Original-Received: from localhost ([::1]:36234 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVyx5-00075k-PW for ged-emacs-devel@m.gmane-mx.org; Thu, 30 Sep 2021 12:30:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44048) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVyWq-0005rz-Dk for emacs-devel@gnu.org; Thu, 30 Sep 2021 12:03:24 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51060) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVyWq-0003Fe-0S; Thu, 30 Sep 2021 12:03:24 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1539 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVyWp-0008IK-Hs; Thu, 30 Sep 2021 12:03:23 -0400 In-Reply-To: <87lf3ew3k5.fsf@gnu.org> (message from Tassilo Horn on Thu, 30 Sep 2021 16:10:02 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275913 Archived-At: > From: Tassilo Horn > Date: Thu, 30 Sep 2021 16:10:02 +0200 > Cc: Eli Zaretskii , emacs-devel@gnu.org, > rudiwillalwaysloveyou@gmail.com, Stefan Kangas > > `dired-create-destination-dirs' already exists. But in Rudi's most > recent patch version, he added a new one. > > --8<---------------cut here---------------start------------->8--- > +(defcustom dired-create-destination-dirs-trailing-separator-special nil That's a mouthful, IMO. How about dired-create-dirs-with-trailing-slash instead? > Rudi proposed that the default value should probably be `t' given that > this feels so intuitive and the only gotcha is renaming/moving or > copying a directory source/ to a non-existent target or target/ where > the former has rename/make a copy semantics and the latter has move/copy > *into* the to be created target/ directory. Please don't make it t by default. I'm quite sure you didn't consider all the use cases. E.g., what about foo -> Foo on case-insensitive filesystems? That is a valid use case where the user wants a directory renamed with a different letter-case. We should only turn it on by default after it has been tested by enough users for long enough.