From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50660: 28.0.50; Text artifacting when the cursor moves over text under mouse face that originally displayed a box Date: Thu, 14 Oct 2021 11:58:19 +0300 Message-ID: <83wnmgkmok.fsf@gnu.org> References: <87czp6ysw7.fsf.ref@yahoo.com> <838rzs4i09.fsf@gnu.org> <87fsu06oxi.fsf@yahoo.com> <83ee9j3ju3.fsf@gnu.org> <834kaf3ets.fsf@gnu.org> <8335pz3dli.fsf@gnu.org> <87r1dj4q4m.fsf@yahoo.com> <83zgs71su7.fsf@gnu.org> <87k0jb4k5l.fsf@yahoo.com> <83sfxz1pw0.fsf@gnu.org> <87o88m14g0.fsf@yahoo.com> <83sfxyxeer.fsf@gnu.org> <87h7ee1252.fsf@yahoo.com> <83pmt2xcox.fsf@gnu.org> <87lf3myhlb.fsf@yahoo.com> <87a6jzvnpq.fsf@yahoo.com> <83o88fom1k.fsf@gnu.org> <871r5bvex8.fsf@yahoo.com> <83v92mkzft.fsf@gnu.org> <87k0j0rwo3.fsf@yahoo.com> <838rzbddfa.fsf@gnu.org> <878rzbd1w5.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5686"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 50660@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 14 10:59:25 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mawaC-0001J3-By for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Oct 2021 10:59:24 +0200 Original-Received: from localhost ([::1]:54482 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mawaB-0006IF-5q for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Oct 2021 04:59:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54112) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mawZq-0006FR-QW for bug-gnu-emacs@gnu.org; Thu, 14 Oct 2021 04:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51318) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mawZq-0003Lc-HC for bug-gnu-emacs@gnu.org; Thu, 14 Oct 2021 04:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mawZq-0000pN-GK for bug-gnu-emacs@gnu.org; Thu, 14 Oct 2021 04:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Oct 2021 08:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50660 X-GNU-PR-Package: emacs Original-Received: via spool by 50660-submit@debbugs.gnu.org id=B50660.16342019143144 (code B ref 50660); Thu, 14 Oct 2021 08:59:02 +0000 Original-Received: (at 50660) by debbugs.gnu.org; 14 Oct 2021 08:58:34 +0000 Original-Received: from localhost ([127.0.0.1]:34631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mawZN-0000oe-NA for submit@debbugs.gnu.org; Thu, 14 Oct 2021 04:58:33 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52132) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mawZJ-0000oP-O4 for 50660@debbugs.gnu.org; Thu, 14 Oct 2021 04:58:32 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:39592) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mawZD-0002pT-IC; Thu, 14 Oct 2021 04:58:24 -0400 Original-Received: from [87.69.77.57] (port=4119 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mawZD-0006nB-5B; Thu, 14 Oct 2021 04:58:23 -0400 In-Reply-To: <878rzbd1w5.fsf@yahoo.com> (message from Po Lu on Sat, 02 Oct 2021 20:52:58 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217202 Archived-At: > From: Po Lu > Cc: larsi@gnus.org, 50660@debbugs.gnu.org > Date: Sat, 02 Oct 2021 20:52:58 +0800 > > Thanks for the comments, I'm attaching a rectified patch. Thanks, I installed this on the master branch with a few minor stylistic fixes. In the future, please try posting a patch formatted with "git format-patch", or at least accompany the patch with a ChangeLog-style commit log entry. (I wrote the log message for you this time.) It looks like something is still amiss: the cursor blinking display is incorrect in some cases. For example, evaluate this in a buffer under Fundamental mode: (insert (propertize "some sample text" 'face '(:box 10) 'mouse-face 'highlight)) and then put the mouse pointer above the text, so it's highlighted, and move the text cursor to the first 's' or the last 't'. As long as the cursor blinks, you will see two characters drawn in the cursor face, not one as expected. Also, in your original recipe with list-faces-display, if the text cursor is at the first character of the "abcdefg..." text of a line with mode-line-highlight face, moving the mouse pointer to and from the text, thus intermittently highlighting and de-highlighting it, leaves artifacts of the 'a' character on display. So I'm not closing this bug yet, as some work still needs to be invested to clean up those minor remaining issues. Thanks.