From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: stefan@marxist.se, shuguang79@qq.com, 50752@debbugs.gnu.org
Subject: bug#50752: 28.0.50; easy-menu-define lowers the menu-bar key
Date: Tue, 19 Oct 2021 20:37:52 +0300 [thread overview]
Message-ID: <83wnm8c3v3.fsf@gnu.org> (raw)
In-Reply-To: <8735oxc51n.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 19 Oct 2021 19:12:20 +0200)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: stefan@marxist.se, shuguang79@qq.com, 50752@debbugs.gnu.org
> Date: Tue, 19 Oct 2021 19:12:20 +0200
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > I think we can leave the behavior with raw bytes as it is, and still
> > document this use case as being meant for ASCII conversions, leaving
> > the subtle case of raw bytes ... subtle.
>
> Yup.
>
> The following patch seems to do the trick, and should be conservative
> enough for emacs-28, I think.
I wouldn't start such experiments on the release branch. It's not an
urgent problem.
> +static int
> +ascii_casify_character (bool downcase, int c)
> +{
> + Lisp_Object cased = CHAR_TABLE_REF (downcase?
> + uniprop_table (Qlowercase) :
> + uniprop_table (Quppercase),
> + c);
> + return FIXNATP (cased) ? XFIXNAT (cased) : c;
> +}
uniprop_table is somewhat expensive, and is definitely an overkill for
converting pure ASCII characters. Why not just set/reset the 0x20
bit?
next prev parent reply other threads:[~2021-10-19 17:37 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 8:39 bug#50752: 28.0.50; easy-menu-define lowers the menu-bar key Shuguang Sun via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-23 17:15 ` Juri Linkov
2021-09-23 21:45 ` Lars Ingebrigtsen
2021-10-12 22:22 ` Stefan Kangas
2021-10-13 11:28 ` Lars Ingebrigtsen
2021-10-13 11:59 ` Eli Zaretskii
2021-10-13 12:04 ` Lars Ingebrigtsen
2021-10-13 12:19 ` Stefan Kangas
2021-10-13 12:58 ` Lars Ingebrigtsen
2021-10-13 15:26 ` Stefan Kangas
2021-10-13 15:42 ` Lars Ingebrigtsen
2021-10-19 3:22 ` Stefan Kangas
2021-10-19 3:40 ` Lars Ingebrigtsen
2021-10-19 3:52 ` Lars Ingebrigtsen
2021-10-19 11:56 ` Eli Zaretskii
2021-10-19 12:07 ` Lars Ingebrigtsen
2021-10-19 12:17 ` Lars Ingebrigtsen
2021-10-19 12:37 ` Eli Zaretskii
2021-10-19 12:45 ` Lars Ingebrigtsen
2021-10-19 13:24 ` Lars Ingebrigtsen
2021-10-19 16:01 ` Eli Zaretskii
2021-10-19 15:41 ` Eli Zaretskii
2021-10-19 15:57 ` Lars Ingebrigtsen
2021-10-19 16:12 ` Eli Zaretskii
2021-10-19 16:15 ` Lars Ingebrigtsen
2021-10-19 16:21 ` Lars Ingebrigtsen
2021-10-19 16:30 ` Eli Zaretskii
2021-10-19 17:12 ` Lars Ingebrigtsen
2021-10-19 17:37 ` Eli Zaretskii [this message]
2021-10-19 18:21 ` Lars Ingebrigtsen
2021-10-20 11:28 ` Eli Zaretskii
2021-10-20 11:55 ` Glenn Morris
2021-10-24 20:11 ` Stefan Kangas
2021-10-25 13:06 ` Lars Ingebrigtsen
2021-10-25 13:19 ` Eli Zaretskii
2021-10-25 13:21 ` Lars Ingebrigtsen
2021-10-25 13:51 ` Eli Zaretskii
2021-10-25 13:55 ` Lars Ingebrigtsen
2021-10-25 14:12 ` Eli Zaretskii
2021-10-26 8:38 ` Stefan Kangas
2021-10-26 13:04 ` Eli Zaretskii
2021-10-26 20:24 ` Stefan Kangas
2021-10-27 14:00 ` Eli Zaretskii
2021-10-28 5:29 ` Stefan Kangas
2021-10-28 7:33 ` Eli Zaretskii
2021-10-28 8:06 ` Stefan Kangas
2021-10-28 9:35 ` Eli Zaretskii
2021-10-28 10:49 ` Stefan Kangas
2021-10-28 12:49 ` Eli Zaretskii
2021-10-28 20:44 ` Stefan Kangas
2021-10-21 2:45 ` Lars Ingebrigtsen
2021-10-21 7:26 ` Eli Zaretskii
2021-10-21 13:04 ` Lars Ingebrigtsen
2021-10-20 7:45 ` Lars Ingebrigtsen
2021-10-20 12:24 ` Eli Zaretskii
2021-10-19 11:43 ` Eli Zaretskii
2021-10-19 21:54 ` Stefan Kangas
2021-10-20 12:59 ` Eli Zaretskii
2021-10-13 16:09 ` Eli Zaretskii
2021-10-15 5:59 ` Eli Zaretskii
2021-10-15 18:34 ` Stefan Kangas
2021-10-19 3:18 ` Stefan Kangas
2021-09-23 22:28 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wnm8c3v3.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=50752@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=shuguang79@qq.com \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.