From: Eli Zaretskii <eliz@gnu.org>
To: dick <dick.r.chiang@gmail.com>
Cc: 52440@debbugs.gnu.org, larsi@gnus.org
Subject: bug#52440: 28.0.50; [PATCH] Quis custodiet ipsos custodes (sqlite3)
Date: Sun, 12 Dec 2021 14:01:23 +0200 [thread overview]
Message-ID: <83wnkanib0.fsf@gnu.org> (raw)
In-Reply-To: <87lf0q6otw.fsf@dick> (message from dick on Sun, 12 Dec 2021 06:32:27 -0500)
> From: dick <dick.r.chiang@gmail.com>
> Cc: Lars Ingebrigtsen <larsi@gnus.org>, 52440@debbugs.gnu.org
> Date: Sun, 12 Dec 2021 06:32:27 -0500
>
> EZ> The amount of sqlite stuff in lisp.h is quite small... So I tend
> EZ> to think a separate header is overkill.
>
> Thinking about this in terms of number of bytes added to lisp.h is the
> wrong way to think about it.
If that's the only aspect, perhaps. But it isn't the only aspect:
there are others, which I mentioned, and you elided. Together with
them, the size is relevant to decide between the alternatives.
> I agree that Lisp_Process, while important, doesn't belong in lisp.h.
> That something as ancillary, third-party, and controversial as
> Lisp_Sqlite does get into lisp.h is a testimony about its author.
We are not dogmatic about this stuff. This is C, not C++, so what
goes into what header is not subject to dogma. And this isn't the
case that just files dealing with sqlite will include this header:
every source file that deals with Lisp objects will need it, so at
least conceptually it belongs to lisp.h. Triggering unnecessary
rebuilds is an annoyance during development, so it's no less important
than purity of the headers.
next prev parent reply other threads:[~2021-12-12 12:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-11 21:32 bug#52440: 28.0.50; [PATCH] Quis custodiet ipsos custodes (sqlite3) dick.r.chiang
2021-12-12 6:12 ` Lars Ingebrigtsen
2021-12-12 7:52 ` Eli Zaretskii
2021-12-12 11:32 ` dick
2021-12-12 12:01 ` Eli Zaretskii [this message]
2021-12-12 12:46 ` dick
2021-12-12 13:28 ` Eli Zaretskii
2021-12-12 14:25 ` dick
2021-12-12 14:38 ` Eli Zaretskii
2021-12-12 15:04 ` dick
2021-12-13 1:55 ` Phil Sainty
2021-12-12 11:49 ` Lars Ingebrigtsen
2021-12-12 12:04 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wnkanib0.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=52440@debbugs.gnu.org \
--cc=dick.r.chiang@gmail.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.