From: Eli Zaretskii <eliz@gnu.org>
To: Sebastian Miele <iota@whxvd.name>
Cc: 54329@debbugs.gnu.org
Subject: bug#54329: 28.0.91; custom-prompt-customize-unsaved-options does not return nil
Date: Thu, 10 Mar 2022 20:29:38 +0200 [thread overview]
Message-ID: <83wnh1d5kd.fsf@gnu.org> (raw)
In-Reply-To: <87v8wlg05i.fsf@whxvd.name> (message from Sebastian Miele on Thu, 10 Mar 2022 18:17:02 +0100)
> From: Sebastian Miele <iota@whxvd.name>
> Cc: 54329@debbugs.gnu.org
> Date: Thu, 10 Mar 2022 18:17:02 +0100
>
> The reason that the behavior of
> ‘custom-prompt-customize-unsaved-options’ changed from version 27.2 to
> 28 almost certainly is the following:
>
> ‘custom-prompt-customize-unsaved-options’ calls ‘customize-unsaved’
> which ends with call to ‘custom-buffer-create’. The definition of
> ‘custom-buffer-create’ changed from Emacs 27.2 to Emacs 28. In Emacs
> 27.2 it probably always returned non-nil. In Emacs 28 it always
> returns nil.
>
> However, the (and ...) form in
> ‘custom-prompt-customize-unsaved-options’ depends on
> ‘customize-unsaved’ to always return non-nil in order to be correct.
>
> ‘custom-prompt-customize-unsaved-options’ always had the bug reported
> here. It just did not manifest before ‘custom-buffer-create’ was
> changed from Emacs 27.2 to Emacs 28.
Thanks, this was the information I missed.
I installed a minor variation of your changes on the emacs-28 branch.
Please take a look.
next prev parent reply other threads:[~2022-03-10 18:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 16:19 bug#54329: 28.0.91; custom-prompt-customize-unsaved-options does not return nil Sebastian Miele
2022-03-10 17:09 ` Eli Zaretskii
2022-03-10 17:17 ` Sebastian Miele
2022-03-10 18:29 ` Eli Zaretskii [this message]
2022-03-10 18:55 ` Sebastian Miele
2022-03-10 19:55 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wnh1d5kd.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=54329@debbugs.gnu.org \
--cc=iota@whxvd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.