From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 47dcf72: Fix tooltip text properties showing up in dragged text Date: Wed, 16 Mar 2022 15:42:16 +0200 Message-ID: <83wnguggjr.fsf@gnu.org> References: <8335jihy8v.fsf@gnu.org> <87y21aowkb.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20625"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 16 14:59:59 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUUBx-0005Br-UX for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Mar 2022 14:59:58 +0100 Original-Received: from localhost ([::1]:48562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nUUBw-0005mJ-90 for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Mar 2022 09:59:56 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45186) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUTux-0007i7-6U for emacs-devel@gnu.org; Wed, 16 Mar 2022 09:42:23 -0400 Original-Received: from [2001:470:142:3::e] (port=60150 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUTuw-00077d-TO; Wed, 16 Mar 2022 09:42:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=d6ZiMtYfP8ZK4KfCo7Via46VyNvHT4dfnax8QUeMHAg=; b=Rs7sUOf6vm+e 5pLvboJkKPnLyyiKf+QFrgdg6I0Qh2aQ1ZD5IcUrqLyxnlbDCOB51wFRp/27CsAPm1sgbf/2mviP5 QE1fJfoNOxoHLdqiIc7o7sNbqhpeDj1UiX4y34p3LteY2udXr54q9iK9joJgkIQ2mM++UBHVXOx9X MDCv81SMnCkfdoOoxJqlJBxSrn/mutO40KhdGN25i2HlxFrWGaVzjmkcb8M9Rrx9NHBEIbqUaXqGt bM85lsXsjhSlij8fiKvk4GAkV12Ir27GdGNWzIO0YAQbq0Eadg6/VS6sA6h6c/dWXzErkk0Q8WfDA MpDSCx70D74ZJlr8tifRYA==; Original-Received: from [87.69.77.57] (port=1029 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUTuw-0000lP-8q; Wed, 16 Mar 2022 09:42:22 -0400 In-Reply-To: <87y21aowkb.fsf@yahoo.com> (message from Po Lu on Wed, 16 Mar 2022 21:29:08 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287227 Archived-At: > From: Po Lu > Cc: emacs-devel@gnu.org > Date: Wed, 16 Mar 2022 21:29:08 +0800 > > Eli Zaretskii writes: > > >> diff --git a/lisp/mouse.el b/lisp/mouse.el > >> index b650bea..4eead39 100644 > >> --- a/lisp/mouse.el > >> +++ b/lisp/mouse.el > >> @@ -3097,12 +3097,28 @@ mouse-drag-and-drop-region > >> (frame-pixel-width frame)) > >> (> (cdr location) > >> (frame-pixel-height frame))))) > >> - (tooltip-hide) > >> + (x-hide-tip) > > > > What will this (and other similar changes you did in that commit) do > > when tooltip-use-echo-area is non-nil? > > It'll display a tooltip, which is according to the doc string of > `mouse-drag-and-drop-region-show-tooltip' what that code is supposed to > do (display a tooltip, not a message in the echo area.) tooltip-use-echo-area also displays a tooltip, just in a special way. Is there any reason not to honor it here?