all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: master 47dcf72: Fix tooltip text properties showing up in dragged text
Date: Wed, 16 Mar 2022 15:42:16 +0200	[thread overview]
Message-ID: <83wnguggjr.fsf@gnu.org> (raw)
In-Reply-To: <87y21aowkb.fsf@yahoo.com> (message from Po Lu on Wed, 16 Mar 2022 21:29:08 +0800)

> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Wed, 16 Mar 2022 21:29:08 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> diff --git a/lisp/mouse.el b/lisp/mouse.el
> >> index b650bea..4eead39 100644
> >> --- a/lisp/mouse.el
> >> +++ b/lisp/mouse.el
> >> @@ -3097,12 +3097,28 @@ mouse-drag-and-drop-region
> >>                                    (frame-pixel-width frame))
> >>                                 (> (cdr location)
> >>                                    (frame-pixel-height frame)))))
> >> -                (tooltip-hide)
> >> +                (x-hide-tip)
> >
> > What will this (and other similar changes you did in that commit) do
> > when tooltip-use-echo-area is non-nil?
> 
> It'll display a tooltip, which is according to the doc string of
> `mouse-drag-and-drop-region-show-tooltip' what that code is supposed to
> do (display a tooltip, not a message in the echo area.)

tooltip-use-echo-area also displays a tooltip, just in a special way.
Is there any reason not to honor it here?



  reply	other threads:[~2022-03-16 13:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-16 12:34 master 47dcf72: Fix tooltip text properties showing up in dragged text Eli Zaretskii
2022-03-16 13:29 ` Po Lu
2022-03-16 13:42   ` Eli Zaretskii [this message]
2022-03-16 13:45     ` Po Lu
2022-03-16 14:25       ` Eli Zaretskii
2022-03-17  0:33         ` Po Lu
2022-03-17  6:49           ` Eli Zaretskii
2022-03-17  7:04             ` Po Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83wnguggjr.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.