Re: Emacs 28 on OSX: emacsclient.c:1415: warning: implicit declaration of function 'openat'

[Eli Zaretskii <eliz@gnu.org>]

> Date: Sun, 17 Apr 2022 10:49:31 -0700
> From: Paul Eggert <eggert@cs.ucla.edu>
> Cc: Keith David Bershatsky <esq@lawlist.com>, Emacs Devel <emacs-devel@gnu.org>
> Instead of using Gnulib openat, I installed the attached patch into the 
> emacs-28 branch so that Emacs uses openat only on platforms like GNU 
> that define O_PATH (as these are the only platforms where Emacs passes a 
> value other than AT_FDCWD to openat's first argument). I tested this in 
> an artificial Fedora environment where I removed O_PATH, and it passed 
> 'make check', so this should port to OS X 10.9 as well. Please give it a 
> try.

I reverted it.  This kind of change on a stable branch, and for the
benefit of an old macOS version on top of that, is unimaginable.  We
use 'open' and 'openat' in many places, and this change affects all of
them.  Please don't make any such changes without discussing them
first.

> PS. Could we somehow arrange for port-to-old-macOS testing to be done 
> before an Emacs release, rather than after?

Hear, hear!  If the pretest period is not used to test on some
platform, users of that platform will have to live with unresolved
bugs.