From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#55070: 28.1; desktop-load doesn't work in -nw (non-gui) emacs Date: Wed, 27 Apr 2022 20:16:45 +0300 Message-ID: <83wnfabg5e.fsf@gnu.org> References: <83fsm4pbs4.fsf@gnu.org> <6961B895-263C-4632-AA4E-8DE29D6160BC@swenson.org> <83sfq3op15.fsf@gnu.org> <86wnfcxnvf.fsf@mail.linkov.net> <87mtg8i1za.fsf@gnus.org> <86h76fu9q5.fsf@mail.linkov.net> <83r15jltce.fsf@gnu.org> <86sfpzspz4.fsf@mail.linkov.net> <83o80nlnjm.fsf@gnu.org> <86fslysc14.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9369"; mail-complaints-to="usenet@ciao.gmane.io" Cc: eric@swenson.org, 55070@debbugs.gnu.org, larsi@gnus.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 27 19:20:58 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1njlLV-0002BE-8Y for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 27 Apr 2022 19:20:57 +0200 Original-Received: from localhost ([::1]:33752 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njlLT-0004Mb-UD for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 27 Apr 2022 13:20:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39550) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njlIh-0001x3-1D for bug-gnu-emacs@gnu.org; Wed, 27 Apr 2022 13:18:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50316) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njlIg-0000Hx-OA for bug-gnu-emacs@gnu.org; Wed, 27 Apr 2022 13:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1njlIg-0006fp-CA for bug-gnu-emacs@gnu.org; Wed, 27 Apr 2022 13:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Apr 2022 17:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55070 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch Original-Received: via spool by 55070-submit@debbugs.gnu.org id=B55070.165107982425572 (code B ref 55070); Wed, 27 Apr 2022 17:18:02 +0000 Original-Received: (at 55070) by debbugs.gnu.org; 27 Apr 2022 17:17:04 +0000 Original-Received: from localhost ([127.0.0.1]:44211 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njlHj-0006eN-UF for submit@debbugs.gnu.org; Wed, 27 Apr 2022 13:17:04 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njlHi-0006dr-Rr for 55070@debbugs.gnu.org; Wed, 27 Apr 2022 13:17:03 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60986) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njlHd-0000Bb-5E; Wed, 27 Apr 2022 13:16:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=NCYtyttmuSC/VhvOmkty+PP442lWyxxPUGV4ZU+MUtA=; b=FsuxlE0w/UUF gIcLgkEI4nabhg9YFEH6/GFFv9D3SZrvhJZ3Nl84iVP0ZSnc7rcEmzcPZGIFPP/dxs1Kyc6P3xqev BKjNNgBvZoH7PSvHyB+CtlEcbJLD/D4/NkD5WKSUhRRlbo9D0jMrkNiCfCh1QuntljL7JAIak+Jwt HuJ4ZeppxWgcdcOZguE+ne4Mgi2iaO9vIegahMmNPsc8HnSisbPwWX89WcwE0FID4Wvuy7qSMxKRQ gf5TfV2pvMTWRtkWHs/42c/DQSNj0vWqfi1DgBZtrmkLR4tYzCbWo5KDJW39L7oeQE4uSL2lOhA90 TCDClepM5NsZ0b7ngwRmSw==; Original-Received: from [87.69.77.57] (port=2937 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njlHb-0001Ji-Mv; Wed, 27 Apr 2022 13:16:56 -0400 In-Reply-To: <86fslysc14.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 27 Apr 2022 19:53:43 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:230806 Archived-At: > From: Juri Linkov > Cc: larsi@gnus.org, eric@swenson.org, 55070@debbugs.gnu.org > Date: Wed, 27 Apr 2022 19:53:43 +0300 > > >> > Thanks, but I don't understand why you need the frameset part of the > >> > patch. > >> > >> Because restoring frames on tty fails without this fix. > > > > Restoring frames is desktop.el's business, so it should be fixed > > there. > > The sole purpose of frameset.el is to save and restore frames. > So the bug was fixed in frameset.el. If you want to teach frameset.el to deal with TTY frames, the patch should explicitly test for TTY frames _inside_ frameset.el. The way you proposed to fix it will do the same on GUI frames, where this situation _should_ signal an error. > > Why does "emacs -nw" at all save frame coordinates if they > > cannot be restored? > > "emacs -nw" doesn't save frame coordinates. Then the fix you proposed cannot help the OP, AFAIU, because his use case was to always use -nw sessions. > > I hope we can find a more elegant and explicit solution to this issue. > > I provided the patch to fix this bug. > If you know how to fix it better, this would be fine. I suggested a way to fix it. I'm not saying my suggestion is the only possible solution, but it's IMO better than what you proposed in at least one aspect.