all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Wamm K. D." <jaft.r@outlook.com>
Cc: 55900@debbugs.gnu.org
Subject: bug#55900: [PATCH] Hierarchy – Defer the Computation of Children
Date: Sat, 11 Jun 2022 11:21:52 +0300	[thread overview]
Message-ID: <83wndny5i7.fsf@gnu.org> (raw)
In-Reply-To: <BY5PR07MB70293D38F7457CFD3E136D1799A99@BY5PR07MB7029.namprd07.prod.outlook.com> (jaft.r@outlook.com)

> From: "Wamm K. D." <jaft.r@outlook.com>
> Date: Sat, 11 Jun 2022 01:52:13 -0500
> 
> Pretty much as the subject describes; this should allow for users to
> lazily load hierarchy branches when loading everything at once would
> otherwise be too consuming, up-front (or if dealing with an infinite
> tree).

Thanks.

> * lisp/emacs-lisp/hierarchy.el (hierarchy-add-tree) (hierarchy-add-trees):
> Add parameter 'delay-children-p'.

Please use our style of commit log messages.  The above should be

* lisp/emacs-lisp/hierarchy.el (hierarchy-add-tree)
(hierarchy-add-trees): Add parameter 'delay-children-p'.

> +(defun hierarchy--create-delayed-tree-widget (elem labelfn indent fn)
> +  "Return a list of tree-widgets for a hierarchy created from the childrenfn.

The first line of the doc string should ideally mention the
arguments.  This one doesn't, and it also seems to misname one
argument: it's FN, not childrenfn, right?

Can this be improved?

Can you add some tests of this new functionality?

Also, I think this warrants a NEWS entry to describe the new feature.





  reply	other threads:[~2022-06-11  8:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-11  6:52 bug#55900: [PATCH] Hierarchy – Defer the Computation of Children Wamm K. D.
2022-06-11  8:21 ` Eli Zaretskii [this message]
2022-06-12  9:01   ` Wamm K. D.
     [not found]   ` <87mtei1cii.fsf@outlook.com>
2022-06-12  9:07     ` Jaft
2022-07-28  8:48       ` Eli Zaretskii
     [not found]     ` <1383718586.2581914.1655024858024@mail.yahoo.com>
2022-07-27 12:36       ` Jaft
2022-07-28  8:52         ` Eli Zaretskii
2022-08-04  0:20           ` Jaft
2022-08-04  6:12             ` Eli Zaretskii
2022-10-27 16:13               ` Jaft
2022-10-27 17:17                 ` Eli Zaretskii
2022-10-27 19:14                   ` Jaft
2022-10-28  7:36                     ` Eli Zaretskii
2022-10-28  7:52                       ` Jaft
2022-10-28  7:56                         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83wndny5i7.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=55900@debbugs.gnu.org \
    --cc=jaft.r@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.