From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: philipk@posteo.net, emacs-devel@gnu.org, info@protesilaos.com
Subject: Re: [elpa] externals/denote e24c9ddc12 2/2: Merge pull request #36 from jeanphilippegg/allow-no-keywords
Date: Thu, 07 Jul 2022 19:04:54 +0300 [thread overview]
Message-ID: <83wnco52op.fsf@gnu.org> (raw)
In-Reply-To: <jwvsfndc4tp.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Thu, 07 Jul 2022 11:37:30 -0400)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: emacs-devel@gnu.org, Protesilaos Stavrou <info@protesilaos.com>
> Date: Thu, 07 Jul 2022 11:37:30 -0400
>
> >> (mapcar (if denote-allow-multi-word-keywords
> >> #'denote--sluggify
> >> #'denote--sluggify-and-join)
> >> keywords))
> >
> > Is there any substantial advantage to pulling the if into the mapcar?
>
> It's good for karma because you get to reduce code duplication.
Not if you are being paid by LOC count.
next prev parent reply other threads:[~2022-07-07 16:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <165707985011.9601.627786867785409616@vcs2.savannah.gnu.org>
[not found] ` <20220706035731.254D5C01681@vcs2.savannah.gnu.org>
2022-07-06 4:30 ` [elpa] externals/denote e24c9ddc12 2/2: Merge pull request #36 from jeanphilippegg/allow-no-keywords Stefan Monnier
2022-07-06 4:41 ` Protesilaos Stavrou
2022-07-07 15:34 ` Philip Kaludercic
2022-07-07 15:37 ` Stefan Monnier
2022-07-07 16:04 ` Eli Zaretskii [this message]
2022-07-10 13:25 ` Robert Pluim
2022-07-11 1:37 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wnco52op.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=info@protesilaos.com \
--cc=monnier@iro.umontreal.ca \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.