From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56469: 29.0.50; Unibyte dir in directory_files_internal Date: Sat, 09 Jul 2022 21:53:25 +0300 Message-ID: <83wncm15ju.fsf@gnu.org> References: <83y1x2177x.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8732"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56469@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 09 20:54:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oAFat-00023H-Rm for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 09 Jul 2022 20:54:20 +0200 Original-Received: from localhost ([::1]:50630 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oAFas-0007uT-Ch for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 09 Jul 2022 14:54:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43652) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oAFac-0007u7-56 for bug-gnu-emacs@gnu.org; Sat, 09 Jul 2022 14:54:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42019) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oAFab-0003Jx-Sq for bug-gnu-emacs@gnu.org; Sat, 09 Jul 2022 14:54:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oAFab-0001rN-Pu for bug-gnu-emacs@gnu.org; Sat, 09 Jul 2022 14:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Jul 2022 18:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56469 X-GNU-PR-Package: emacs Original-Received: via spool by 56469-submit@debbugs.gnu.org id=B56469.16573928307130 (code B ref 56469); Sat, 09 Jul 2022 18:54:01 +0000 Original-Received: (at 56469) by debbugs.gnu.org; 9 Jul 2022 18:53:50 +0000 Original-Received: from localhost ([127.0.0.1]:35916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAFaP-0001qw-Rt for submit@debbugs.gnu.org; Sat, 09 Jul 2022 14:53:50 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAFaN-0001qk-W0 for 56469@debbugs.gnu.org; Sat, 09 Jul 2022 14:53:48 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48456) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oAFaI-0003Ic-0x; Sat, 09 Jul 2022 14:53:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=rOyy9p9LXUBUf3vrvG0cgncvzVaf4mRkHhd/Qjlqnho=; b=Q+0tQVGn8TeK 6wKEKsQ5lLPo/CDi2ohA4iUEMSrG00lGoUFkm/7pfyhdTzRYscPZFRSR7C0M2dH3gC2hOS/wwnYXd OI5S7PLdam6h4Mb/2T2sm7hmPX6AdIcBuxgzEFTr352czvffS6bf8AkrT28PmGz4o+l26L2+MlyxK RKgFZfoxEbulGxaXeW9gTguXwk0KXyperKfktHwdsvKMyCpuqv29ivvb+j6ZBcpDRgJHOdtAk1XIS rYlsccqjH8gcRNtEEDAevZLKvfOncsFs8CfWj/j8XDVairSP0IjCy7Z2QVJ1kuf7xoITWbDId3n5T uezeWHa9R1znW2s6vchqMw==; Original-Received: from [87.69.77.57] (port=1778 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oAFaH-0003r9-KH; Sat, 09 Jul 2022 14:53:41 -0400 In-Reply-To: (message from Stefan Monnier on Sat, 09 Jul 2022 14:20:37 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236532 Archived-At: > From: Stefan Monnier > Cc: 56469@debbugs.gnu.org > Date: Sat, 09 Jul 2022 14:20:37 -0400 > > >> I suggest the patch below. In a comment I suggest we don't try to use > >> unibyte strings when a multibyte string would work as well. This is > >> because for those ASCII-only strings, it's cheaper to test bytes==chars > >> to (re)discover that they are ASCII-only (when they're multibyte) than > >> having to loop through the bytes (when they're unibyte). > > > > Please bootstrap Emacs in a directory with such a name, and if that > > works, I'm okay with installing this change. > > Just to clarify: by "this change" you refer to the change in the patch > or the change suggested in the comment? I meant the patch. The comment I didn't understand at all. It seemed to be unrelated to the code and the change you were proposing.