From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56561: 29.0.50; Infloop in try_window Date: Sat, 16 Jul 2022 11:22:12 +0300 Message-ID: <83wncdqxfv.fsf@gnu.org> References: <874jzjwmhn.fsf@md5i.com> <83v8rzsdd1.fsf@gnu.org> <878rovxqjo.fsf@md5i.com> <83sfn2sy19.fsf@gnu.org> <83lesusl4w.fsf@gnu.org> <87lesumqgf.fsf@yahoo.com> <83ilnysbc5.fsf@gnu.org> <83fsj2s8fg.fsf@gnu.org> <83cze6s7xt.fsf@gnu.org> <83bktqs724.fsf@gnu.org> <878rotlpck.fsf@yahoo.com> <834jzhsj1a.fsf@gnu.org> <87v8rxk3eb.fsf@yahoo.com> <83zgh9r2he.fsf@gnu.org> <87lestk18e.fsf@yahoo.com> <83y1wtqzqp.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33210"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mwd@md5i.com, 56561@debbugs.gnu.org To: luangruo@yahoo.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 16 10:23:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oCd4w-0008Ue-AU for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Jul 2022 10:23:10 +0200 Original-Received: from localhost ([::1]:48172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oCd4u-0007jy-VW for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Jul 2022 04:23:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52538) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCd4p-0007jo-3f for bug-gnu-emacs@gnu.org; Sat, 16 Jul 2022 04:23:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45097) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oCd4o-0000hl-RB for bug-gnu-emacs@gnu.org; Sat, 16 Jul 2022 04:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oCd4o-0002bI-Ib for bug-gnu-emacs@gnu.org; Sat, 16 Jul 2022 04:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Jul 2022 08:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56561 X-GNU-PR-Package: emacs Original-Received: via spool by 56561-submit@debbugs.gnu.org id=B56561.16579597459938 (code B ref 56561); Sat, 16 Jul 2022 08:23:02 +0000 Original-Received: (at 56561) by debbugs.gnu.org; 16 Jul 2022 08:22:25 +0000 Original-Received: from localhost ([127.0.0.1]:42856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCd4C-0002aE-OG for submit@debbugs.gnu.org; Sat, 16 Jul 2022 04:22:24 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCd4B-0002a1-Aq for 56561@debbugs.gnu.org; Sat, 16 Jul 2022 04:22:23 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54366) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCd46-0000f1-3y; Sat, 16 Jul 2022 04:22:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=txSMAI/tu4dtH9zx0VKCLCNNuNNJ3p2YuNYxLcqXqoM=; b=rpZtmxAiTvE6 ycsCIRLO1m+1ohMuTJaluXy5aS2qre/L5eOYBYgZu1FVkXTyi0jYiNpABDkvLW/aW43QAg7r+S/2z U/iKHs5RuIYObTnGLNBAqG0f/7AzD1dukx0xmo6PO9jbaW7Mik88d/VdltgKnnNmZ0JRS6ZUOXMK5 QIoaXeIxcZnJZfSapF+iLrVe78tjH735zd8eA/U+mk015hJj8C/qOdchwBS1Sowm7yXNL202DwM5k 4/SOiKCx/CC+kp0rShR6JjCjApvfjlE7VffBY3uqnDjxGIJIqXhEkIwwl83vd+LK8jo+FRHY7nRxy whnbKqjXo15n0XSKL8Hinw==; Original-Received: from [87.69.77.57] (port=1880 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCd45-0000aP-HK; Sat, 16 Jul 2022 04:22:17 -0400 In-Reply-To: <83y1wtqzqp.fsf@gnu.org> (message from Eli Zaretskii on Sat, 16 Jul 2022 10:32:30 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237150 Archived-At: > Cc: mwd@md5i.com, 56561@debbugs.gnu.org > Date: Sat, 16 Jul 2022 10:32:30 +0300 > From: Eli Zaretskii > > > > The situation that started this bug report is one such case: my fix > > > will cause try_window to return zero in that case. But if the entire > > > text was processed and is in the glyph matrix, that zero return value > > > doesn't mean a failure. > > > > That isn't what the comment above try_window says about its return > > value: > > > > Value is 1 if successful. It is zero if fonts were loaded during > > redisplay which makes re-adjusting glyph matrices necessary, and -1 > > if point would appear in the scroll margins. > > (We check the former only if TRY_WINDOW_IGNORE_FONTS_CHANGE is > > unset in FLAGS, and the latter only if TRY_WINDOW_CHECK_MARGINS is > > set in FLAGS.) > > I'm reading the code, not the commentary. I will fix the commentary > to be more accurate Now done.